--- Log opened Sun Nov 02 00:00:34 2014 00:12 #navit: <@KaZeR> bafplus: how is it going with the patch? 00:19 #navit: < bafplus> just finished patching 00:19 #navit: < bafplus> opening onother beer, this ones empty now... 00:19 #navit: < bafplus> Tried to run a build but get n error... 00:20 #navit: <@KaZeR> gist :) 00:22 #navit: < bafplus> i'm a little confused here...just trying to make a build for linux 00:22 #navit: < bafplus> cd into a build folder (empty) 00:23 #navit: < bafplus> and do "make" would start the build... 00:23 #navit: < bafplus> make: *** Geen doelen opgegeven en geen makefile gevonden. Gestopt. 00:23 #navit: < bafplus> No target given and no makefile found. Stopped 00:25 #navit: <@KaZeR> you need to run cmake before 00:25 #navit: <@KaZeR> to create the makefiles 00:25 #navit: < bafplus> from within the source folder right? 00:25 #navit: <@KaZeR> usually there's two build system : autotools and cmake 00:26 #navit: <@KaZeR> cmake has the benefit of not putting cruft in your source directory 00:26 #navit: <@KaZeR> so you need to create a directory to build 00:26 #navit: < bafplus> i know about cmake...what i dont understand that if i cmake it , say, yesterday the files should still be there... 00:26 #navit: <@KaZeR> if you are in navit's root, you can do mkdir build; cd build; cmake ../navit / 00:26 #navit: <@KaZeR> they should if you are in the directory from which you triggered the build 00:29 #navit: < bafplus> ok, so did that, cmake config went fine...but then i call "make" and there's the error again... 00:30 #navit: < woglinde> good night 00:30 #navit: < bafplus> i'm doing something fundamentaly wrong here (suspect its something quite simple) 00:31 #navit: < bafplus> Good night wogline 00:31 #navit: <@KaZeR> bye woglinde 00:31 #navit: <@KaZeR> bafplus: can you share your console log ? 00:31 #navit: < bafplus> response in terminal you mean? 00:32 #navit: <@KaZeR> yep 00:32 #navit: < bafplus> make: ***No targets given and no makefile found. Stopped. 00:33 #navit: < bafplus> Thats it... 00:33 #navit: <@KaZeR> ok. please share what you did before 00:35 -!- woglinde [~henning@p4FE4D467.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 00:35 #navit: < bafplus> cd ~ , mkdir build , cd build, cmake navit-source 00:35 #navit: <@KaZeR> so cmake should complain 00:36 #navit: <@KaZeR> because i doubt there is something in navit-source :) 00:36 #navit: < bafplus> but it didnt 00:36 #navit: < bafplus> well...the source files are in navit-source 00:37 #navit: <@KaZeR> in your build directory? so ~/build/navit-source ? 00:37 #navit: < bafplus> user/home/navit-source/navit/ 00:37 #navit: < bafplus> user/home/build 00:37 #navit: <@KaZeR> so you cmake command would be cmake ../navit-source/navit 00:37 #navit: < bafplus> or user/home/navit-build 00:38 #navit: < bafplus> lets try that one... 00:38 #navit: <@KaZeR> both should work 00:39 #navit: < bafplus> Cmake gives no error, but when the cmake is finished yoy normaly just call "make" to start the build en then the error comes up 00:41 #navit: < bafplus> Lets start from scratch... 00:41 #navit: <@KaZeR> :) 00:41 #navit: < bafplus> I dowloaded the svn into user/home/navit-source 00:42 #navit: < bafplus> So you have home/user/navit-source/navit/ 00:42 #navit: < bafplus> home/user/navit-source/toolchain/ 00:43 #navit: < bafplus> etc, ect 00:44 #navit: < bafplus> Then i mkdir a build directory, like home/user/build end cd into it 00:44 #navit: < bafplus> I run cmake, no error 00:44 #navit: <@KaZeR> cmake with what arguments ? 00:44 #navit: <@KaZeR> you need to tell him where to find navit's sources 00:44 #navit: < bafplus> With run i mean "cmake navit-source" 00:45 #navit: <@KaZeR> nop : then it would be looking for navit-source in your build directory 00:45 #navit: <@KaZeR> you need to run cmake ../navit-source in your use case 00:45 #navit: < bafplus> so... 00:45 #navit: <@KaZeR> (or you can create build in navit-source and then just run cmake ../ ) 00:45 #navit: < bafplus> cd ~ 00:45 #navit: < bafplus> cmake navit-source 00:46 #navit: <@KaZeR> that will work but will clutter your homedir :) 00:47 #navit: < bafplus> hehe... 00:47 #navit: < bafplus> cd build 00:47 #navit: < bafplus> cmake ../navit-source 00:47 #navit: < bafplus> works, no error 00:47 #navit: < bafplus> So my current location is still the build folder 00:48 #navit: < bafplus> now just simple call "make" right? 00:48 #navit: <@KaZeR> So my current location is still the build folder -> what do you mean ? 00:48 #navit: < bafplus> Fram start to finish ;-) 00:48 #navit: < bafplus> cd ~ 00:48 #navit: < bafplus> mkdir build 00:48 #navit: < bafplus> cd build 00:49 #navit: < bafplus> cmake ../navit-source 00:49 #navit: <@KaZeR> this looks good so far 00:49 #navit: < bafplus> make 00:49 #navit: < bafplus> ERROR 00:50 #navit: <@KaZeR> what message? 00:51 #navit: < bafplus> bart@bart-CF-19AHNAHF4:~/build$ make 00:51 #navit: < bafplus> make: *** Geen doelen opgegeven en geen makefile gevonden. Gestopt. 00:51 #navit: <@KaZeR> let's restart from scratch : 00:51 #navit: <@KaZeR> cd ~ 00:51 #navit: <@KaZeR> rm -rf build 00:51 #navit: <@KaZeR> rm -rf navit-source 00:51 #navit: <@KaZeR> svn co ... 00:52 #navit: <@KaZeR> cd navit 00:52 #navit: <@KaZeR> mkdir build; cd build 00:52 #navit: <@KaZeR> cmake ../ && make 00:52 #navit: <@KaZeR> this should work 00:52 #navit: < bafplus> mind if i rename the source folder first ;-) 00:52 #navit: <@KaZeR> no, it's up to you :) 00:53 #navit: < bafplus> if i remove it i lose my patch etc ;-) 00:53 #navit: <@KaZeR> sure 00:59 #navit: < bafplus> building..... 00:59 #navit: < bafplus> wtf am i doing wrong with the other one... 00:59 #navit: <@KaZeR> you probably messed up with some paths at some point 01:00 #navit: < bafplus> probably... 01:00 #navit: < bafplus> well...i will run this build, quick copy paste my edited files back and rerun the build. 01:07 #navit: <@KaZeR> or you can create a patch from your previous tree and reapply it :) 01:07 #navit: <@KaZeR> cd /navit 01:08 #navit: <@KaZeR> svn diff > bafplus.patch 01:08 #navit: <@KaZeR> hop! you have a patch 01:10 #navit: < bafplus> so i have a "current svn" folder and a folder where i already did my changes. 01:11 #navit: < bafplus> I cd into "custom changes folder"/navit 01:11 #navit: < bafplus> and run svn diff > name for patch? 01:14 #navit: <@KaZeR> yep 01:17 #navit: < bafplus> dams...there still was a refferance to isAdressFilter...changed it...building... 01:19 #navit: < bafplus> wow...buils is succesfull, but them i open home/user/navit there is NO build folder... 01:20 #navit: < bafplus> hmm...when trying to make it in terminal (mkdir) it says its already there... 01:20 #navit: < bafplus> but not when i open it in the foldernavigator 01:20 #navit: <@KaZeR> if you used my sequence of commands, it would be ~/navit/build 01:20 #navit: <@KaZeR> not ~/build 01:21 #navit: < bafplus> if i open ~/navit i see ni build folder 01:23 #navit: <@KaZeR> try to paste your history somewhere, we can figure it out 01:23 #navit: <@KaZeR> or if you are still in the folder where you ran build, try "pwd 01:23 #navit: < bafplus> i can however open navit from terminal 01:24 #navit: <@KaZeR> so pwd will help 01:24 #navit: < bafplus> no map AND no locale.... 01:25 #navit: <@KaZeR> whet's your current folder ? 01:26 #navit: < bafplus> home/bart/navit-custom/build/ 01:26 #navit: < bafplus> pwd gives that same patch 01:27 #navit: < bafplus> you know what...its 2:30 here, i will reboot in windows and test youre exe and then i'm off to bed... 01:30 #navit: <@KaZeR> you can test the build later if it's late no worries :) 01:32 #navit: < bafplus> i have to do something in win before i go so quick test is possible 01:32 #navit: < bafplus> brb 01:32 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Remote host closed the connection] 01:34 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 01:37 #navit: < bafplus> kazer, you're installer opens, it installs navit to the porgramm-files folder, but nothing is in it except the uninstaller 01:39 #navit: < bafplus> hold on...i'm on a 64-bit windows...could that be a isue? 01:41 #navit: < bafplus> well i'm of, thanks again for the guidance and tomorrow is another day ;-) 01:41 #navit: <@KaZeR> sure, good night 01:42 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- Now with extra fish!] 01:42 #navit: <@KaZeR> thanks for the report i'll have a look 01:44 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 01:44 #navit: < bafplus> kazer, installer works! 01:45 #navit: < bafplus> i think it is because it installed in the "program files" folder the first time, but there is a space in the mapname, that could give problems. Just installed it in c:/navit amnd that works 01:46 #navit: < bafplus> gonnan test the actual exe tomorow...and there is no map btw... 01:46 #navit: < bafplus> see ya! 01:46 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Client Quit] 06:31 -!- drlizau [~liz@billiau.net] has joined #navit 07:54 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 07:56 #navit: < bafplus> kazer , still here? 09:03 -!- woglinde [~henning@p4FE4D467.dip0.t-ipconnect.de] has joined #navit 09:04 -!- woglinde_ [~henning@p4FE4D467.dip0.t-ipconnect.de] has joined #navit 09:08 -!- woglinde [~henning@p4FE4D467.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 09:09 -!- woglinde_ is now known as woglinde 10:47 -!- drlizau [~liz@billiau.net] has quit [Remote host closed the connection] 12:23 -!- woglinde [~henning@p4FE4D467.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds] 12:25 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- Would you like to know more?] 12:28 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 14:11 -!- udovdh [~udovdh@pindarots.xs4all.nl] has joined #navit 14:32 #navit: < bafplus> Goedemiddag udo 14:36 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Remote host closed the connection] 14:38 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 14:40 #navit: < bafplus> KaZeR , awake yet? 14:44 -!- Brinky [brinky@faui2k3.org] has quit [Ping timeout: 258 seconds] 14:44 -!- Brinky [brinky@faui2k3.org] has joined #navit 15:50 -!- udovdh [~udovdh@pindarots.xs4all.nl] has quit [Quit: Leaving] 16:33 -!- jandegr [50c83758@gateway/web/freenode/ip.80.200.55.88] has joined #navit 17:03 #navit: <@KaZeR> hey there 17:05 #navit: < jandegr> hi kazer 17:05 #navit: <@KaZeR> what's up bafplus 17:05 #navit: <@KaZeR> hi jandegr 17:06 #navit: <@KaZeR> i'll update the translations today jandegr. for real :) 17:07 #navit: < jandegr> no prob, only trying to reduce the number of open tickets 17:09 #navit: < bafplus> hy kazer...i just "forked" navit to ghithub 17:10 #navit: < bafplus> i was wondering what to do when there is a new commit in the svn, is there a way to update/pull tha change? 17:11 #navit: <@KaZeR> bafplus: there is, but the complexity of it highly depends of how you did your fork ( e.g. if you did setup a tracking branch or not ) 17:12 #navit: <@KaZeR> bafplus: more and more people are forking navit to github. maybe i should do a vanilla fork of the trunk, that i would keep in sync myself, so that people can just submit pull request that we could easily merge back into svn. i'll think about it 17:15 #navit: < bafplus> i think that would be a great idea 17:16 #navit: < bafplus> just for my info, if i make a branch of that repo, and make a custom change. Then when the main repo is updated with a commit i can pull ONLY tha commit into my branch without losing my own changes... 17:18 #navit: < bafplus> btw, youre install exe works, just 2 things: By default it will install in the programfiles folder, but in some translations (like dutch) that foldername contains a space "Program Files" 17:18 #navit: <@KaZeR> mmmm. changes in branches are not affected by other branches, unless you do a merge 17:19 #navit: <@KaZeR> that means that your branch with your change will not evolve with the master branch 17:19 #navit: <@KaZeR> makes sense? 17:19 #navit: < bafplus> i had isues with that space before. If i install it to , say, c:// it works fine 17:19 #navit: <@KaZeR> if you update navit in the master branch, your test branch will still use a previous version of navit 17:20 #navit: < bafplus> Yes that make sence, my goal is to have a "source" that i can costimize and when the master is being updated i can pull that change into my own custom branch 17:21 #navit: < bafplus> so its more a one-way system, just to update my own version instead of pushing a change back to the main branch 17:21 #navit: < bafplus> and the installer doesent have any maps, is that correct? 17:22 #navit: < bafplus> btw...the country images work in youre exe...what did you do that i didnt to make those work? 17:23 #navit: < bafplus> I guess i miss some dependancies for tose images... 17:26 #navit: < jandegr> kazer #483 seems to be comitted in r2635 , if you confirm I want to ask how does one use this from within xml ? 17:26 #navit: < jandegr> bafplus have you used that, you're the xml expert :) 17:26 #navit: <@KaZeR> bafplus: interesting for the country images... 17:30 #navit: < bafplus> jandegr, i havent used that, and reading the ticket, i have no clue what that could be...sorry... 17:30 #navit: <@KaZeR> jandegr: i do see most of the patch in the trunk indeed 17:30 #navit: <@KaZeR> it's probably an attribute on the osd itself from what i understand 17:30 #navit: <@KaZeR> let me check 17:32 #navit: < jandegr> kazer I see the patch comitted completely , would be a nice feature and if cp15 comitted it , it must have worked back then 17:32 #navit: < jandegr> but wiki says nothing about it. 17:33 #navit: < jandegr> from what I understand from the ticket it shows the turn after the next turn, and more if wanted. 17:34 #navit: <@KaZeR> jandegr: exactly. i've never seen this attribute before, good catch :) 17:34 #navit: <@KaZeR> i did a test, it's really easy : just add level="" to the osd 17:35 #navit: <@KaZeR> if no level is specified, 0 is assumed 17:35 #navit: <@KaZeR> so you can theoricaly add as many of them as you want 17:36 #navit: < jandegr> be back in 30' and if test succeeds, I'll enter it in the wiki and you can close the ticket :) 17:38 #navit: <@KaZeR> i'm updating the ticket already :) and looks like there's some spam in it 17:46 #navit: < bafplus> kazer, if i put my own exe in the folder youre install made (so replacing the shipped exe with my own) the country images are NOT shown, telling me that the error is in the exe itself 17:46 #navit: < bafplus> The linux build doesent have this isue, but building the win32 exe does have this problem. 17:47 #navit: < bafplus> So my guess would be some misspelling in a folderpath or something generated during the win32 build 17:47 #navit: <@KaZeR> mmm. i would need the output of your own build's cmake to investigate 17:48 #navit: < bafplus> the outputlogfile? 17:49 #navit: <@KaZeR> that would be a start 17:49 #navit: < bafplus> path? (just to make sure i give you the correct one...) 17:50 #navit: <@KaZeR> should be in the root of your navit folder 17:50 #navit: <@KaZeR> afk a few 17:50 #navit: < bafplus> https://gist.github.com/bafplus/25057daf2a201fd8ca44 17:52 #navit: < bafplus> btw...you said you tested the wiki, can you send me that complete build? You should have the same error than... 18:14 #navit: <@KaZeR> i tested the wiki ? 18:14 #navit: <@KaZeR> you mean your doc to build the .exe ? 18:15 #navit: < bafplus> yes, so that would resulted in an exe, can you send it to be? That one should have that same error 18:27 -!- curious [~curious@ejb106.internetdsl.tpnet.pl] has joined #navit 18:29 #navit: < bafplus> jandegr , question...is it possible for an osd button to toggle the autozoom state? 18:30 #navit: < jandegr> ues bafplus 18:31 #navit: < jandegr> 18:34 #navit: <@KaZeR> bafplus: all the steps i used are here : https://drone.io/github.com/pgrandin/navit/admin 18:35 #navit: <@KaZeR> guys, i'd love to see your osds! don't be shy, share them :) 18:35 #navit: <@KaZeR> we can even build automated screenshots for each navit commit to check for regressions 18:40 #navit: < bafplus> That drone.io , is that some online building service? 18:41 #navit: < bafplus> Now you're ad it jandegr ;-) , what would the code be to send a line of text to the speech function? 18:42 #navit: < bafplus> I'm doing some backtracking of changes and hints/tricks...i lost a few on the way 18:43 #navit: < jandegr> kazer I tested #483 with level="1" and level="2", worked perfect, I updated the wiki accordingly, thx :) 18:43 #navit: <@KaZeR> thanks for the wiki update jandegr 18:43 #navit: <@KaZeR> bafplus: yes drone.io is a SaaS for CI 18:46 #navit: <@KaZeR> bafplus: for the speech function: http://wiki.navit-project.org/index.php/OSD#Commands -> say("text") 18:53 #navit: < jandegr> btw folks, I don't like forks, semi-devs will not try to get their improvements in the main branch anymore :( 18:55 #navit: < bafplus> in my case, thats just what i want ;-) 18:56 #navit: < jandegr> it's the death of some opensource projects 18:59 #navit: <@KaZeR> jandegr: well i'm not sure. people who do changes on their end might keep them for themselves also without a fork. i mean nothing forces them to submit a patch request 19:00 #navit: <@KaZeR> jandegr: if you don't contribute back your changes, then you will have to maintain your code. otherwise getting updates from the trunk can be painful 19:00 #navit: <@KaZeR> before github, i'm sure a lot of people would just keep their patches local, and we just never know about it 19:01 #navit: < bafplus> like my situation, i want to keep a fork including my own changes, just for personal use, and keep it updated with changes in the main repo. But when i get to a point that i manage to make a change that would benefit the project i off course push that to the main repo 19:01 #navit: <@KaZeR> if you are doing a fork on a public repo, it might show up in a search engine, and it's still better 19:01 #navit: < bafplus> i dont mind if its public 19:02 #navit: < jandegr> ok, I take my words back :) 19:03 #navit: < bafplus> btw kazer , i now have setup a few buttons to print a short message in the log for marking porposes 19:03 #navit: <@KaZeR> jandegr: you have the right to disagree :) 19:04 #navit: <@KaZeR> bafplus: cool! github! wiki! :) 19:04 #navit: < bafplus> Any idea for the comand to print a clean message? With the "say" command it would end up something like : navit:speech_say:this_=0x44605e8 text='**************test***************' 19:04 #navit: < jandegr> but just look at how much work is involved in scouting the tickets already no (sample 1 hour ago), then who will scout all those forks for code to merge to main ? 19:04 #navit: < bafplus> and a second line that the spech engine cant find a corrsponding wav file (duh!) 19:05 #navit: < jandegr> typo : but just look at how much work is involved in scouting the tickets already noW (see sample 1 hour ago), then who will scout all those forks for code to merge to main ? 19:05 #navit: < bafplus> its the user sesponsibility tio send a pull request to the owner of the main repo right? 19:06 #navit: <@KaZeR> jandegr: https://github.com/search?l=C&q=navit&type=Repositories&utf8=%E2%9C%93 could be a start 19:06 #navit: < bafplus> but see it this way...that way you have something to scout, if you now donlowd the source and make a patch....it isnt to be found in anyway 19:08 #navit: < bafplus> with git it is documented SOMEWHERE... 19:09 #navit: <@KaZeR> oh, look at this : https://github.com/motokokusanagi/tnav/blob/master/traffic.c 19:09 #navit: <@KaZeR> an attempt to add traffic updates :) 19:10 #navit: <@KaZeR> looks like it gets updated via a dbus call. interesting 19:11 #navit: <@KaZeR> jandegr: i believe that it advocates toward forks and repo :) that guy wrote a poc plugin back in 2012.. and since it's public, it's not lost and we can resume the work, two years later 19:13 #navit: < jandegr> kazer you got a point there 19:21 #navit: < bafplus> Kazer , about the marks, can you give me a few different type of marks that you find usefull? 19:21 #navit: < bafplus> Like wrong turn, roadblock , strange misdirection etc... 19:22 #navit: < bafplus> not to much, i would like to see the map with al the OSD buttons ;-) 19:22 #navit: < bafplus> I have room for about 5 different "marks" 19:25 #navit: < bafplus> About the traffic updates...does that take the traffic in account when routing? If yes, please do pick that up ;-) 19:41 #navit: <@KaZeR> bafplus: about marks, we can start with just a few items that are relevant now and expand or alter the list later, i wouldm't worry much about it 19:42 #navit: <@KaZeR> for the traffic, the big difficulty is to find a reliable source. there are already a few mechanisms to push traffic updates in navit, but you highly depend on the traffic source 19:42 #navit: <@KaZeR> please see http://trac.navit-project.org/ticket/570 19:43 #navit: <@KaZeR> if you happen to find a reliable source i'd be really happy to add it 19:45 #navit: < jandegr> for the netherlands we can use bafplus as source :) 19:47 #navit: < bafplus> That would be mostly noord-brabant jandegr ;-) 19:47 #navit: <@KaZeR> haha :) 19:49 #navit: < jandegr> or kazer sets up a server and in Navit a button : "report traffic jam" and every Navit user contributes and consumes traffic info at the same time :) 19:50 #navit: <@KaZeR> that would be technically possible, but i doubt our user community is big enough today to be worth the effort 19:52 #navit: < jandegr> just kidding, but still think navit has potential for a much bigger community 19:57 #navit: <@KaZeR> i do. we just need to raise the awareness :) 19:57 #navit: < bafplus> like a multilangual website 19:57 #navit: < bafplus> iphone/android apps in the store 19:58 #navit: < bafplus> but there sure is pptential 19:58 #navit: < bafplus> afk for a while.. 20:03 #navit: < jandegr> googleplay android Navit installs 500000 - 1000000 but last update august 16 2012 20:06 -!- tryagain [~quassel@178.216.76.91] has joined #navit 20:07 #navit: <@KaZeR> yep. win32 build automation is fixed. next one, android :) 20:07 #navit: <@KaZeR> and i know somebody who will work on a new website design soon. i18n is a good idea. if you think of anything you'd like to see on the new website, please let me know 20:08 #navit: < jandegr> kazer make apkg fails at the end , but can manage to make an apkg using eclipse. 20:08 #navit: <@KaZeR> jandegr: you start the build from eclipse only ? 20:08 #navit: <@KaZeR> i'd like to put that into drone too. automation and scripting is the key 20:09 #navit: < tryagain> jandegr: how make apkg fails at the end? 20:09 #navit: < jandegr> no, first make , goes ok , and then make apkg fails, then in eclips "run as android app", at the same time makes an apkg :) thx eclipse ! 20:10 #navit: < tryagain> we have automated builds at f-droid, and our nigtly builds work ok for android. All without eclipse. 20:10 #navit: < jandegr> yes tryagain, I'll post details some time next week 20:11 #navit: < tryagain> ok 20:12 #navit: < jandegr> tryagain : from my side #1243 is finished with the 3rd. version, I think it's yours now :) 20:20 #navit: < tryagain> jandegr great, reading it 20:20 #navit: < tryagain> at line 2072 there's a c++ism 20:20 #navit: < tryagain> of binfile.c 20:21 #navit: < jandegr> tryagain I am a java guy, that's why someone like you reviews it :) 20:21 #navit: < bafplus> If you need help with a new website, i'm in for it ;-) 20:22 #navit: < tryagain> understood, i'll call it javaism in the future 20:24 #navit: < jandegr> is it " struct coord tc; " ? 20:25 -!- drlizau [~liz@billiau.net] has joined #navit 20:27 #navit: < tryagain> jandegr yes, in C variable declarations should be at the beginning of code block. It's not allowed to intermix them with code. 20:27 #navit: < jandegr> ok, thanks 20:28 #navit: < jandegr> as in not allowed by convention ? 20:28 #navit: < jandegr> or does gcc catch and correct it ? 20:33 #navit: < tryagain> it's not allowed by C standard, but gcc allows it as an extension. It's allowed in C++ standard. 20:34 #navit: < jandegr> clear 20:36 #navit: < tryagain> iirc, passing variables by reference like "void increment(int &i){i++;}" would work in gcc. Its another C++ism. 20:38 #navit: < jandegr> but that is found all over in the existing code, isn't it ? 20:43 #navit: <@KaZeR> bafplus: help proposal recorded. i'll let you know once i'll get a design. meanwhile, start thinking about the features you'd like to see. maybe we should open a ticket to track ideas and discussions 20:44 -!- drlizau [~liz@billiau.net] has quit [Remote host closed the connection] 20:44 -!- _rd [~rd@p54AC73B2.dip0.t-ipconnect.de] has joined #navit 20:45 #navit: < tryagain> jandegr unsure if we have lots of those, but there might be some. I don't think i've seen a single variable passed by reference. 20:46 #navit: < jandegr> ok, probably my mistake. 20:56 #navit: < tryagain> bafplus your envelpe looks good, but i would like to have it filled with some solid color, like it's done in our existing envelope 20:56 #navit: < bafplus> kazer, that would be quite a big list of ideas ;-) 20:57 #navit: < bafplus> tryagain, hmm.... that IS the same envelope.... 20:57 #navit: <@KaZeR> bafplus: keep in mind that for some advanced features, we have the wiki, trac, etc :) 20:58 #navit: < bafplus> i used the existing envelope. What do you mean with solid color? the background? 20:59 #navit: < bafplus> so no transparancy? 20:59 #navit: < tryagain> yes, background inside the envelope itself, transparency around it 21:00 #navit: < bafplus> there should already be some solid color is that is present in the original... 21:00 #navit: < bafplus> that was post.svg right? 21:01 #navit: < bafplus> ir did i pick the wrong icon to use as base? 21:06 #navit: < tryagain> bafplus sorry, it was me not noticed that original image is also semitransparent. Your is ok. 21:07 #navit: < tryagain> I've read you have adopted the patch to current svn codebase? Can you share it? ;) 21:09 #navit: < bafplus> sure...if i fugure out how to generate the patch correctly ;-) 21:09 #navit: < bafplus> haven't tried it yet 21:10 #navit: <@KaZeR> svn diff bafplus :) 21:10 #navit: < bafplus> wil be afk for a while but going to boot up in linux later 21:10 #navit: < bafplus> i know kazer, but havent tried that yet ;-) 21:11 #navit: <@KaZeR> sure 21:11 #navit: < bafplus> svn diff > filename.patch 21:12 #navit: < bafplus> brb booting now... ;-) 21:12 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- Nine out of ten l33t h4x0rz prefer it] 21:13 #navit: < tryagain> jandegr btw another C++/javaism is // comments. There are tons of those in existing code, but we should try to eliminate them. 21:16 #navit: < jandegr> ok, found on the wiki programming guidelines "Use /* and */ for comments instead of // " 21:16 #navit: <@KaZeR> http://wiki.navit-project.org/index.php/Programming_guidelines 21:16 #navit: <@KaZeR> haha exactly 21:18 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 21:18 #navit: < jandegr> aha, now my turn "Please comment your code in a significant and reasonable way. " 21:18 #navit: < bafplus> tryagain https://gist.github.com/bafplus/a4002afa774b02416e99 21:19 #navit: < jandegr> and make life of newbies easier :) 21:19 #navit: < bafplus> i second that jandegr 21:20 #navit: <@KaZeR> jandegr: yes we really need to improve this. but it's everyone's responsability :) 21:20 #navit: <@KaZeR> we have a history of bad habit with comments. we need to fix that 21:22 #navit: < jandegr> if tryagain is through with #1243 I might go over binfile.c to add comments according to my findings 21:23 #navit: < bafplus> kazer , heres the patch to change the green numbers to black in the speedwarner. I leave it to you to change it or leave it as is ... https://gist.github.com/bafplus/ef6da2d2f18a41a6d72a 21:26 #navit: <@KaZeR> jandegr: that's an excellent idea, thanks a lot 21:26 #navit: < bafplus> tryagain, when you edit the zipcodepatch to use the new icon, can you give me the new patch with correct icon back? 21:26 #navit: <@KaZeR> thanks bafplus. maybe we should make this configurable via navit.xml 21:27 #navit: < bafplus> that would be great kazer, the more we can define in xml the better, my next project is the zoomlevels in autozoom, they don't fit nice on a big win32 screen 21:28 #navit: < bafplus> would be nice to also define those zoomlevels from the xml 21:28 #navit: < bafplus> among onther functions ;-) 21:28 #navit: < bafplus> jandegr, did you add the toggle function for autozoom in the wiki or shall i do that? 21:29 #navit: < bafplus> afk... 21:47 -!- jandegr [50c83758@gateway/web/freenode/ip.80.200.55.88] has quit [Quit: Page closed] 21:58 -!- Navit [~Navit@www.v6.navit-project.org] has quit [Quit: Coyote finally caught me] 21:59 -!- Navit [~Navit@www.v6.navit-project.org] has joined #navit 21:59 #navit: < Navit> Hi! 21:59 #navit: < tryagain> bafplus svn 5819 is commited, together with zipcode.svg 22:00 #navit: < tryagain> *5918 22:12 #navit: < bafplus> Great! Thanks 22:14 #navit: < bafplus> just to check if this noob understands it .... if i download the svn now *5918 is already in it? 22:16 #navit: < tryagain> Yes. It's enough to do "svn up" in your source directory. Unless there are some confliction changes you done in the code. 22:16 #navit: < tryagain> *conflicting 22:17 #navit: < bafplus> btw, already verry happy with that patch, but can we put it on the roadmap that you can perform the zipcodesearch directly in the townsearch? 22:18 #navit: < bafplus> and does svn up overwrite any custom changes? 22:19 #navit: < tryagain> we can put it on roadmap (ticket on trac) 22:20 #navit: < tryagain> svn up attempts to merge changes, and shows cases where a conflict exists 22:20 #navit: < tryagain> it will be up to you to resolve them 22:21 #navit: < bafplus> aha...got some conflicts but that maybe because i already manualy dit the zipcodepatch? 22:23 #navit: < bafplus> whats do they mean with "my side of conflict" and "their side of conflict" ? 22:30 #navit: <@KaZeR> my side = your local change, their side = code from trunk 22:31 #navit: <@KaZeR> there might be conflicts if you changed the same lines in a slightly different manner 22:31 #navit: <@KaZeR> if you don't have specific changes appart from the patch, you can svn checkout 22:32 #navit: < bafplus> its just that the code from svn is "cleaner", code itself is the same so in my case "ts" ;-) 22:36 #navit: < bafplus> where can i find the autozoom code? gui? osd? 22:41 #navit: <@KaZeR> this is a core feature, so navit/navit.c 22:50 #navit: < bafplus> found it....hmmm...that going to be more then changing a simple number....going to pick that up later... 22:50 #navit: < bafplus> I'm of, thanks for the help again guys! 22:56 #navit: <@KaZeR> ++ bafplus 22:59 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Quit: Leaving] 23:07 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has joined #navit 23:08 #navit: < bafplus> tryagain, just builded the latest svn. image in zipcodesearch is not visable, the function works when you click in the area where the icon should be. 23:08 #navit: < tryagain> rerun cmake, then rebuild 23:08 #navit: < bafplus> i tried replasing the zipcode.png with the original post.png, doesent work 23:09 #navit: < tryagain> looks like you have not actually patched the code 23:09 #navit: < bafplus> ah..that maybe it, figured i could skip that to build the exe, so only ran the cmake toolchain and make... 23:10 #navit: < tryagain> make should build the exe 23:12 #navit: < bafplus> it works for me now, its a bit to late to reboot, remake, reboot test etc...going to do that tomorow and see if that works... 23:12 #navit: < bafplus> good night! 23:13 -!- bafplus [~bafplus@5ED0A3EE.cm-7-1c.dynamic.ziggo.nl] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- The alternative IRC client] --- Log closed Mon Nov 03 00:00:33 2014