--- Log opened Thu May 04 00:00:54 2017 00:45 -!- j_f-f [~quassel@rs-6.jff-webhosting.net] has quit [Remote host closed the connection] 00:48 -!- j_f-f [~quassel@rs-6.jff-webhosting.net] has joined #navit 02:20 -!- jjelen [jjelen@nat/redhat/x-xabchwffflnysebl] has joined #navit 03:02 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 05:59 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Ping timeout: 255 seconds] 06:00 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 10:42 -!- jjelen [jjelen@nat/redhat/x-xabchwffflnysebl] has quit [Ping timeout: 240 seconds] 11:34 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.] 11:46 -!- robertp [5849da94@gateway/web/freenode/ip.88.73.218.148] has joined #navit 11:55 #navit: < kazer> hi there 11:55 #navit: < robertp> Hi Kazer 11:56 #navit: < kazer> robertp: could you please attach a screenshot to #235 showing the difference? 11:56 #navit: < robertp> mh.... probably 11:57 #navit: < kazer> it would help the review. I think it would be a good habit to show exactly the impact of the changes 11:58 #navit: < robertp> OSD configuration is a on/off switch... If it matches, the image (or scale) is visible otherwise not. One screenshot wouldnt fit, i guess. 11:59 #navit: < robertp> Kazer, I have a question. I browsed through the tickets and found a ticket related to street names: http://trac.navit-project.org/ticket/1251 12:00 #navit: < robertp> I grepped myself through the code but didnt find the place where the rendering is calculated... can you point me to the peice of code that mus be touched? 12:03 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 12:32 #navit: < kazer> for the osd configuration, the expected behavior is that we could disable a scale for example when we also disable another component.. so a screenshot showing them visible, then hidden would work 12:33 #navit: < kazer> i don't want to burden you, just trying to spread up good practices that'll help us review faster :) 12:39 -!- jandegr [5bb34aad@gateway/web/freenode/ip.91.179.74.173] has joined #navit 13:04 #navit: < kazer> robertp: i think i found what you were looking for : https://github.com/navit-gps/navit/blob/trunk/navit/graphics.c#L1248 13:04 #navit: * kazer shakes fist at our crappy comments 13:06 #navit: < robertp> not only the comments are crappy, the var names are also horror 13:06 #navit: < kazer> haha yeah 13:07 #navit: < kazer> the sqrt function was my pointer here, i figured that we were probably using that to compute the length of a segment 13:08 #navit: < kazer> feel free to improve the things that are confusing... We have a CI to catch (some) problems! 13:10 #navit: < robertp> mh... #235 breaks my osd configuration... 13:10 #navit: < jandegr> kazer the comments are 100% correct 13:10 #navit: < jandegr> * FIXME 13:11 #navit: < kazer> jandegr: yep, indeed :) 13:12 #navit: < jandegr> but if you have a rainy day I have smth else 13:12 #navit: < jandegr> https://github.com/navit-gps/navit/commit/8363731af73d71afec3aad1c6145f759570e3e7f 13:12 #navit: < jandegr> don't know if you received a notice about the comment 13:13 #navit: < kazer> i did yes, thanks. going to address that today. 13:14 #navit: < kazer> also just faced the qt5 cmake issue on my local machine, the one you mentionned yesterday that is breaking routing-qa 13:14 #navit: < jandegr> I thought to start with an easy comment, but the one you mention is bad 13:15 #navit: < kazer> it is indeed 13:18 #navit: < jandegr> AFAIK all QT5 can be set disable by default, somebody wants QT5 then specify it in the cmake command line 13:20 #navit: < kazer> well, we could do that.. But then when you want to enable qt5 it still breaks. I'm trying to fix it 13:31 -!- robertp [5849da94@gateway/web/freenode/ip.88.73.218.148] has quit [Ping timeout: 260 seconds] 13:44 -!- robertp [5849da94@gateway/web/freenode/ip.88.73.218.148] has joined #navit 14:46 #navit: < jandegr> kazer can you give me access to the maptool branch ? 14:46 #navit: < jandegr> pls ? 14:50 #navit: < kazer> the maptool branch? 14:50 #navit: < jandegr> meant maptool repo 14:50 #navit: < kazer> ah sure 14:50 #navit: < jandegr> thx 14:51 #navit: < kazer> done 14:53 #navit: < jandegr> thx, now try to figure out how you did that :) 14:53 #navit: < jandegr> mean get all those maps built 14:55 #navit: < kazer> ah 14:55 #navit: < kazer> :) 14:55 #navit: < kazer> the magic of branches :) 14:56 #navit: < kazer> since each branch maps to a map name in geofabrik, we can download a map from geofabrik easily 14:56 #navit: < jandegr> I suppose kick master is enough, but I would exlude oceans because of flooding 14:56 #navit: < kazer> but then we have the flooded map problem... 14:56 #navit: < kazer> exactly 14:56 #navit: < jandegr> so I must change a line in each of the 60 branches or so ???? 15:01 #navit: < kazer> you should not need to 15:01 #navit: < kazer> you should only need to trigger a build for the branch you are interested in 15:01 #navit: < jandegr> ok, but 1 flooder floods all 15:01 #navit: < kazer> damn flooders! 15:02 #navit: < jandegr> we nead floaters 15:02 #navit: < kazer> water pumps! global warming! 15:02 #navit: < jandegr> found a much better really simple way 15:03 #navit: < kazer> to avoid flooding? 15:03 #navit: < jandegr> a snorkel solution 15:03 #navit: < jandegr> make QA not display oceans by modding xml or so 15:04 #navit: < kazer> works for qa indeed, but still not great to serve maps from circleci 15:04 #navit: < jandegr> and then rebuild maps on a need to basis in a 1 by 1 fashion, without oceans 15:05 #navit: < kazer> i like the idea, it would be nice to have good looking results from QA 15:05 #navit: < jandegr> I do have that, and it even runs on a simple demand, no try to make navit have that too 15:06 #navit: < jandegr> now try to ... 15:06 #navit: < kazer> great 15:06 -!- robertp [5849da94@gateway/web/freenode/ip.88.73.218.148] has quit [] 15:11 #navit: < jandegr> ah kazer , that same Issue I suppose https://circleci.com/gh/navit-gps/maptool/765 15:26 #navit: < kazer> indeed 15:26 #navit: < kazer> will fix it thanks 15:34 #navit: < jandegr> we thank you instead 15:35 -!- jandegr [5bb34aad@gateway/web/freenode/ip.91.179.74.173] has quit [Quit: Page closed] 16:51 -!- noradtux [~noradtux@port-11636.pppoe.wtnet.de] has quit [Ping timeout: 255 seconds] 16:52 -!- noradtux [~noradtux@2a02:2028:627:f301:a966:18dd:34ed:22e1] has joined #navit 18:53 -!- pmckinley [~Peter_McK@88-110-196-194.dynamic.dsl.as9105.com] has joined #navit 18:54 #navit: < pmckinley> Hectic 18:54 #navit: < pmckinley> :-$ 18:57 #navit: < pmckinley> knock knock 19:06 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.] 19:21 -!- pmckinley [~Peter_McK@88-110-196-194.dynamic.dsl.as9105.com] has left #navit [] 19:52 -!- Horwitz [~mich1@p200300800E039A00022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 20:05 -!- Horwitz [~mich1@p200300800E032200022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 20:05 -!- mode/#navit [+o Horwitz] by ChanServ 23:18 -!- circleci-bot [~circleci-@54.237.27.195] has joined #navit 23:18 #navit: < circleci-bot> Success: pgrandin's build (#1803; push) in navit-gps/navit (trunk) -- https://circleci.com/gh/navit-gps/navit/1803?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc 23:18 -!- circleci-bot [~circleci-@54.237.27.195] has quit [Client Quit] --- Log closed Fri May 05 00:00:56 2017