--- Log opened Sat Jan 20 00:00:02 2018
00:07 -!- Horwitz [~mich1@p200300800E0B7300022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
00:20 -!- Horwitz [~mich1@p200300800E2E3300022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit
00:20 -!- mode/#navit [+o Horwitz] by ChanServ
00:39 #navit: < Navit> The following compiles failed: http://download.navit-project.org/logs/navit/android_armv5te/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/osm-exp/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/src/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/openmoko/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/win32/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/n
00:39 #navit: < Navit> oad.navit-project.org/logs/navit/android_armv4t/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/android_x86/svn/navit-svn-.failed http://download.navit-project.org/logs/navit/tomtom/svn/navit-svn-.failed
00:39 #navit: < Navit> See compile results history at http://download.navit-project.org/logs/navit/stats.html
01:41 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has quit [Ping timeout: 268 seconds]
01:47 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has joined #navit
03:46 -!- noradtux [~noradtux@port-7505.pppoe.wtnet.de] has quit [Ping timeout: 256 seconds]
03:46 -!- noradtux [~noradtux@2a02:2028:724:4501:ec4:7aff:fe33:3dc1] has joined #navit
04:15 -!- jeremy_ [~jeremy@rla39-h01-176-133-215-10.dsl.sta.abo.bbox.fr] has joined #navit
04:16 -!- jeremy_ is now known as Guest52869
04:19 -!- youte [~jeremy@rla39-h01-176-133-215-10.dsl.sta.abo.bbox.fr] has quit [Ping timeout: 276 seconds]
05:07 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit
05:07 -!- mode/#navit [+v xenos1984] by ChanServ
06:55 -!- kart [cbbbf7c7@gateway/web/freenode/ip.203.187.247.199] has joined #navit
06:57 #navit: < kart> Hi i am a Navit newbie... i have Qt5.9.1 with me and did a build of navit in qtcreator 
06:57 #navit: < kart> but i am getting loads of error
06:58 #navit: < kart> can anyone give me any documentation regarding the same
07:07 #navit: <@KaZeR> hi kart 
07:08 #navit: <@KaZeR> why did you use qtcreator to build navit? it's not required
07:08 #navit: <@KaZeR> what platform are you building for?
07:17 #navit: < kart> my end target will be x86 with only linuxfb
07:17 #navit: < kart> now i am trying in ubuntu with x server
07:17 #navit: < kart> same architecture
07:20 #navit: <@KaZeR> `ok. i am using linuxfb on arm, it works well. you shouldn't need to use qtcreator. have you tried building using cmake ?
07:21 #navit: < kart> Not yet. That is one of the reason i choose qtcreator 
07:21 #navit: < kart> But i am up for the challenge 
07:23 #navit: <@KaZeR> this is actually simpler :)
07:24 #navit: <@KaZeR> our build configuration isn't meant to be used with qtcreator
07:24 #navit: <@KaZeR> try this :
07:24 #navit: <@KaZeR> - go into the source directory
07:24 #navit: <@KaZeR> - create a folder to host the compiled code : mkdir bin
07:24 #navit: <@KaZeR> - cd bin; and then cmake ../
07:24 #navit: <@KaZeR> this will run cmake against the config at the root of the project
07:25 #navit: <@KaZeR> you will want to ensure that graphics/qt is enabled in the summary
07:25 #navit: <@KaZeR> it might be worth sharing that summary (you can paste using pastebin.com) so that we can double check together if everything is OK
07:25 #navit: <@KaZeR> after that, running "make" should compile navit
07:26 #navit: < kart> Thank you for such detailed explanation. Really appreciate it. 
07:26 #navit: < kart> But i have my qt bin and libs in /opt/
07:27 #navit: <@KaZeR> np, my pleasure
07:27 #navit: < kart> what variable in CMakeLists.txt should be used to set Qt5 path ?
07:27 #navit: <@KaZeR> it's not a problem : part of our build uses pkgconfig which is able to detect where your libs are installed
07:27 #navit: <@KaZeR> unless you have multiple installs of QT i wouldn't be concerned about setting that
07:28 #navit: < kart> so exporting pkgconfig path to my environment would be sufficient ?
07:28 #navit: <@KaZeR> also you usually don't need to tweak CMakeLists.txt, but instead you can use arguments to configure it
07:29 #navit: <@KaZeR> in most cases, just running the cmake example i shared should pick up the dependencies
07:29 #navit: <@KaZeR> the summary at the end of cmake will tell us if everything is OK
07:29 #navit: < kart> Oh okay. I will do that right away then.
07:39 #navit: < kart> I did the cmake 
07:40 #navit: < kart> and here is the summary
07:40 #navit: < kart> https://pastebin.com/XcA6a5y8
07:40 #navit: < kart> i am afraid qt5 libs are not detected in the summary
07:41 #navit: <@KaZeR> it could be that only one is missing. we need to make that message more explicit
07:41 #navit: <@KaZeR> how did you install qt5? ubuntu packages or the unified installer?
07:43 #navit: < kart> @Kazer I am confused. How would navit understand the qt path if it is not in the standard paths ? 
07:44 #navit: < kart> qt5 install prefix is in /opt/ directory
07:44 #navit: < kart> I did my own compilation for qt5
07:45 #navit: < kart> and about the ubuntu packages :  cmake and other packages was installed from the Ubuntu repository 
07:46 #navit: <@KaZeR> try this :  pkg-config --list-all |grep -i qt5
07:48 #navit: < kart> it showing all the qt5 libs.
07:49 #navit: < kart> Qt5 modules to be exact
07:49 #navit: <@KaZeR> ok great. can you share that list? i want to compare it with mine to see which module is missing
07:49 #navit: <@KaZeR> pkg-config is capable of finding packages and libraries in multiple paths. makes life so much easier :)
07:49 #navit: < kart> sure. But before that, can i ask you something ?
07:49 #navit: <@KaZeR> sure
07:51 #navit: < kart> I believe these modules are detected because i have another Qt5 installation from Ubuntu repository. 
07:52 #navit: <@KaZeR> ah! it might be that indeed
07:52 #navit: <@KaZeR> you specifically want to use the ones from /opt and not system-wide?
07:52 #navit: < kart> But simply  "qmake" tells me it cant find the bin file
07:52 #navit: < kart> yes. Correct
07:53 #navit: <@KaZeR> ok. i believe that "export PKG_CONFIG_PATH=/opt" should do that
07:54 #navit: <@KaZeR> export PKG_CONFIG_PATH=/opt/Qt/5.7/gcc_64/lib/pkgconfig rather
07:54 #navit: <@KaZeR> (or the equivalent on your machine)
07:57 #navit: < kart> That did the trick
07:57 #navit: < kart> https://pastebin.com/mZyzPta6
07:58 #navit: < kart> Even though i am not 100% sure that the qt5 libs taken are system ones or the custom one 
07:58 #navit: <@KaZeR> awesome :)
07:58 #navit: <@KaZeR> you can check which libs have been picked up : grep -i qt CMakeCache.txt 
07:59 #navit: <@KaZeR> if you feel so inclined, you could also document what you've learned today in our wiki. https://wiki.navit-project.org/index.php/QML2_GUI#Prerequisites would be a good place
08:00 #navit: < kart> should i be concerned about the line  QT_QMAKE_EXECUTABLE:FILEPATH=NOTFOUND in CMakeCache.txt
08:00 #navit: <@KaZeR> so now that cmake looks happy, you can just run "make"
08:00 #navit: <@KaZeR> no, we don't use qmake
08:00 #navit: < kart> alright 
08:01 #navit: < kart> you mean i can add what i learned today to the wiki page
08:01 #navit: < kart> ?
08:01 #navit: <@KaZeR> yep, i'm sure it'll eventually help someone else
08:02 #navit: <@KaZeR> or maybe even you when you'll want to do that again :)
08:02 #navit: < kart> definetly i will that
08:02 #navit: < kart> i will do that8
08:02 #navit: < kart> i will do that*
08:02 #navit: < kart> sorry for the typo
08:02 #navit: <@KaZeR> np :)
08:02 #navit: < kart> grep -i qt CMakeCache.txt  doesnt give me any path details 
08:03 #navit: < kart> and rather it says not found 
08:03 #navit: < kart> Qt5Positioning_DIR:PATH=Qt5Positioning_DIR-NOTFOUND
08:05 #navit: <@KaZeR> qt5positioning should only be needed if you want to use qt5's wrapper for that. this is kind of specific for qt-based devices like the Jolla
08:06 #navit: <@KaZeR> do you have a path set for QtCore? Qt5Core_DIR:PATH=/usr/lib64/cmake/Qt5Core here
08:06 #navit: < kart> but i do have qt5positioning
08:06 #navit: < kart> Nope, I dont.
08:07 #navit: <@KaZeR> odd
08:07 #navit: <@KaZeR> what happens if you run make ?
08:08 #navit: <@KaZeR> i will have to go afk soon, but i'm often around. other members like jkoan for example can also help you
08:08 #navit: <@KaZeR> in which timezone are you?
08:28 #navit: <@KaZeR> afk, back in a few hours
08:33 -!- Guest52869 is now known as youte
08:33 -!- mode/#navit [+v youte] by ChanServ
08:34 #navit: < kart> @Kazer Sorry, i myself got engaged in someting else. I am in Indian time zone
08:49 #navit: < kart> @Kazer thank you for your support. 
09:38 -!- noradtux [~noradtux@2a02:2028:724:4501:ec4:7aff:fe33:3dc1] has quit [Quit: Bye]
09:39 -!- noradtux [~noradtux@port-6055.pppoe.wtnet.de] has joined #navit
10:19 -!- kart [cbbbf7c7@gateway/web/freenode/ip.203.187.247.199] has quit [Ping timeout: 260 seconds]
13:01 -!- pini [~pini@bou-fi.pustule.org] has joined #navit
16:02 #navit: <+ilovekiruna> Hi KaZeR, hi kart
17:06 -!- pini [~pini@bou-fi.pustule.org] has quit [Ping timeout: 248 seconds]
17:55 #navit: <+jkoan> Hi KaZeR
17:59 #navit: <+jkoan> i think i found a bug :D https://static.jkoan.de/2018-01-20%2018-54-00.flv 
18:01 #navit: <@KaZeR> jkoan: odd! what's that blue area? an OSD?
18:01 #navit: <+jkoan> yes
18:02 #navit: <+jkoan> i try to rebuild this: http://www.rueducommerce.fr/automobile/images/produits/screenshots/ONE_FRONT_FR.jpg
18:05 #navit: <+jkoan> the bug itself is not importent for the layout i am doing, but i think it sould be fixed sometime :D
18:09 #navit: <@KaZeR> i see. can you please log a ticket with your OSD?
18:09 #navit: <+jkoan> i try to :D
18:10 #navit: <+jkoan> KaZeR: do you think its a good idea to have "the tomtom" layout on NavitTom?
18:11 #navit: <@KaZeR> are you concerned that they would sue us for copyright infringement?
18:20 #navit: <+jkoan> when we will not use there images?
18:20 #navit: <+jkoan> ticket done : http://trac.navit-project.org/ticket/1363
18:54 #navit: <@KaZeR> what do you mean with the images?
19:04 -!- jeremy_ [~jeremy@rla39-h01-176-133-215-10.dsl.sta.abo.bbox.fr] has joined #navit
19:04 -!- jeremy_ is now known as Guest10838
19:05 -!- youte [~jeremy@rla39-h01-176-133-215-10.dsl.sta.abo.bbox.fr] has quit [Ping timeout: 268 seconds]
19:18 -!- Guest10838 [~jeremy@rla39-h01-176-133-215-10.dsl.sta.abo.bbox.fr] has quit [Ping timeout: 248 seconds]
19:24 -!- youte [~jeremy@rla39-h01-176-133-215-10.dsl.sta.abo.bbox.fr] has joined #navit
19:50 #navit: <+jkoan> We don't extract any images like png or jpg from there device to publish them. It's only layout and it's only a very old layout, do you think this could become a problem?
20:21 #navit: <+ilovekiruna> KaZeR: how should i now proceed with my warnings? Still PRs? or in one big?
21:16 #navit: <@KaZeR> jkoan: no i don't think that it could be a problem
21:17 #navit: <@KaZeR> ilovekiruna: yeah, PR are great as they allow others to review. https://github.com/navit-gps/navit/pull/390 is a really good example of collaboration
21:17 #navit: <+jkoan> I would vote for a big pr with multiple commits that should not be squatched so we can revert one commit if necessary
21:18 #navit: <@KaZeR> jkoan: i would vote for smaller PRs to avoid the big PR being blocked because one tiny detail bugs someone :)
21:20 #navit: <+jkoan> Would also be good but I personally don't like extremely small PRs because it's a lot of overhead
21:23 #navit: <@KaZeR> what kind of overhead?
21:24 #navit: <@KaZeR> i think that having someone like sleske or metalstrolch review the PR is super useful, as they are really good at writing code, but are not often on IRC to discuss the changes
21:32 #navit: <@KaZeR> actually #390 wasn't the PR i was looking for. anyway :)
21:33 #navit: <+ilovekiruna> KaZeR: could u remind me again, how i can change navit.xml to get a kind of split screen?
21:35 #navit: <@KaZeR> ilovekiruna: auxmap OSD. we *really* need to document it in the wiki this time :)
21:37 #navit: <@KaZeR> ilovekiruna: thanks for the PR. i'm wondering if a "if ( !fread(b->base, b->size, 1, f) ) {" wouldn't be better
21:38 #navit: <+ilovekiruna> which file or line?
21:39 #navit: <@KaZeR> you made a change for that a couple of times in that PR, for example navit/maptool/zip.c:194
21:39 #navit: <+ilovekiruna> I ci it now
21:40 #navit: <+ilovekiruna> u mean just shorten the whol thing?
21:41 #navit: <@KaZeR> yeah, not sure that declaring a variable that we use once is useful, when directly checking the result with an if should yield the same result
21:41 #navit: <+ilovekiruna> sure, could change that
21:42 #navit: <@KaZeR> thanks
21:42 #navit: <+ilovekiruna> then coming days I hope i can make some tests of the changes of OSD
21:43 #navit: <+ilovekiruna> u remember the background?
21:43 #navit: <@KaZeR> the background?
21:49 #navit: <+jkoan> KaZeR: everything is fine, I only meant that one file in a PR is not effective exactly with a ci test for each one
21:50 #navit: <+ilovekiruna> KaZeR: why i want a split screen?
21:50 #navit: <+ilovekiruna> KaZeR: better now? Or should I also change for the write?
21:55 #navit: <+jkoan> ilovekiruna: what do you think about have the same layout on tomtom devices as the original one, so the user experience differs not to much?
21:57 #navit: <+jkoan> ilovekiruna: for PR best would be for all if conditions where we are sue that we don't need the return value again
21:57 #navit: <@KaZeR> ilovekiruna: yeah some of the missing checks actually indicate a flaw in the logic behind the read
21:58 #navit: <@KaZeR> here's an example : https://github.com/hoehnp/navit/blob/95010e97559117e24a0f7ad47ceb1048ff50991e/navit/maptool/ch.c#L208
21:58 #navit: <@KaZeR> your PR fixes the warning, but not the flaw. In this specific example, on top of the warning we should probably skip to the next iteration of the while()
21:59 #navit: <@KaZeR> otherwise on line 224 we will insert a NULL element in the hash table. which is what we are doing today, but isn't greaat
22:05 -!- Netsplit over, joins: Navit
22:16 #navit: <+ilovekiruna> KaZeR: quite possible, 
22:16 #navit: <+ilovekiruna> actually my only goal at that point was to fix warning
22:16 #navit: <+ilovekiruna> s
22:17 #navit: <+ilovekiruna> and i think compared to other software i use, there are not many warnings
22:20 #navit: <@KaZeR> ilovekiruna: yep. although it's worth checking the logic when we fix them, as sometimes it could hide a real potential problem
22:28 #navit: <+ilovekiruna> KaZeR: dont get me wrong. I agree with you. I am just not too deep in the code to see such real potential problems
22:34 #navit: <@KaZeR> that's why multiple people reviewing the PR is important, more chances of catching errors :)
22:34 #navit: <@KaZeR> do you understand the fix i'm suggesting for this one?
22:38 #navit: <+ilovekiruna> I think I do
22:39 #navit: <@KaZeR> ok cool
22:40 #navit: <+ilovekiruna> seems like not much of discussion in the forum on the new logo
22:51 #navit: <@KaZeR> i haven't sent the email yet, still need to do it :)
22:52 #navit: <+ilovekiruna> am a bit worried about it
22:52 #navit: <+ilovekiruna> as i hoped me and jkoan can wear navit shirts on fosdem
22:52 #navit: <+ilovekiruna> but time is flying
22:52 #navit: <+ilovekiruna> KaZeR: can i merge the three commits in one or is it fine to keep them?
22:55 #navit: <@KaZeR> well we can put whatever logo we want on the tshirts without the group opinion. you're 50% of the crowd who's going to wear it :)
22:57 #navit: <+jkoan> The problem is that ilovekiruna and I are not very creative to make the design ;)
22:57 #navit: <@KaZeR> haha i know, same issue here
23:01 #navit: <+ilovekiruna> KaZeR: happy with the continue?
23:03 #navit: <@KaZeR> this one looks good yeah, now we need to look into the other fread occurences :)
23:04 #navit: <+ilovekiruna> I would prefer if we could do the others in one go
23:04 #navit: <+ilovekiruna> dont want to scatter to many commit
23:04 #navit: <+ilovekiruna> s
23:04 #navit: <@KaZeR> as a rule of thumb, we should usually remove #if 0 sections, like the one in buffer.c
23:05 #navit: <@KaZeR> don't worry too much about the commits, we'll squash them anyway
23:06 #navit: <@KaZeR> the correct fix for the fread part in buffer.c would be to return false when fread fails, and return true otherwise. it means changing the return value from void to int
23:06 #navit: <+ilovekiruna> the #if section isnt mine
23:07 #navit: <@KaZeR> i know :)
23:08 #navit: <@KaZeR> http://programmer.97things.oreilly.com/wiki/index.php/The_Boy_Scout_Rule 
23:09 #navit: <+ilovekiruna> wont nothing break if we redefine the return type?
23:10 #navit: <+ilovekiruna> have changed the type and return the values
23:11 #navit: <@KaZeR> nothing should break but we'll get a new warning, about the return value being ignored
23:14 #navit: <+ilovekiruna> so i just create more work again?
23:14 #navit: <+ilovekiruna> KaZeR: is it like u wanted it now?
23:14 #navit: <@KaZeR> more work, but better code :)
23:16 #navit: <+ilovekiruna> just today was dealing with really old code, sometimes to bad that things arent well maintained
23:16 #navit: <@KaZeR> ilovekiruna: yep, but i think we're getting better at this
23:17 #navit: <@KaZeR> ilovekiruna: buffer.c looks good. one last request : would you mind adding a doxygen comment to that function ?
23:17 #navit: <+ilovekiruna> puh
23:17 #navit: <+ilovekiruna> first will need to look up doxygen syntax again
23:17 #navit: <+ilovekiruna> didnt use for ages
23:18 #navit: <+ilovekiruna> KaZeR: seems we have a problem with the latest change
23:18 #navit: <+ilovekiruna> build failed
23:18 #navit: <+ilovekiruna> on linux
23:19 #navit: <@KaZeR> here's a random example :  https://github.com/navit-gps/navit/blob/c9b9a216e21ae2bbe178b0db7bae2d0b406cd2e0/navit/item.c#L133-L144
23:20 #navit: <+ilovekiruna> I like docu like that helps others when they want to work with it, but am always bad at it :(
23:21 #navit: <+ilovekiruna> I guess you want to add now doxygen on all three functions, right?
23:22 #navit: <+ilovekiruna> btw: shouldnt we also at some point update the copyright year number?
23:24 #navit: <@KaZeR> i think that adding documentation to all functions at once is a lot of work, but a good practice would be to do it when we touch one specific function
23:24 #navit: <@KaZeR> so that we eventually document more and more
23:25 #navit: <@KaZeR> and yeah, we should update the (c) the same way : if we update a file, we can update the (c)
23:25 #navit: <+ilovekiruna> I just did in buffer.c
23:25 #navit: <+ilovekiruna> do u know repoman from Gentoo?
23:28 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.]
23:29 #navit: <@KaZeR> thanks
23:29 #navit: <@KaZeR> yep, i've done some ebuild stuff
23:30 #navit: <+ilovekiruna> It would for example also check for that copyright years :-p
23:30 #navit: <@KaZeR> nice :)
23:35 #navit: <+ilovekiruna> KaZeR: can you check again the build error once the testing is done again?
23:45 #navit: <@KaZeR> yep
23:46 #navit: <+ilovekiruna> linux failed already
23:48 #navit: <+ilovekiruna> seems like only the linux build fails
23:51 #navit: <+ilovekiruna> why does it only fail on linux?
23:51 #navit: <+ilovekiruna> I understand the issue i think
--- Log closed Sun Jan 21 00:00:04 2018