--- Log opened Tue Jun 12 00:00:13 2018 04:48 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 04:48 -!- mode/#navit [+v xenos1984] by ChanServ 05:59 -!- naggety [~naggety@205.red-95-125-66.dynamicip.rima-tde.net] has joined #navit 07:20 -!- frankS [~erich_bh@ip-109-41-130-252.web.vodafone.de] has joined #navit 07:25 -!- frankS [~erich_bh@ip-109-41-130-252.web.vodafone.de] has quit [Remote host closed the connection] 07:35 -!- Horwitz [~mich1@p200300800E3B3800022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 07:35 -!- mode/#navit [+o Horwitz] by ChanServ 08:47 -!- Horwitz [~mich1@p200300800E3B3800022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 12:08 -!- Horwitz [~mich1@p200300800E4DA200022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 12:08 -!- mode/#navit [+o Horwitz] by ChanServ 12:19 -!- Horwitz [~mich1@p200300800E4DA200022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 12:23 -!- naggety [~naggety@205.red-95-125-66.dynamicip.rima-tde.net] has quit [Ping timeout: 276 seconds] 12:39 -!- naggety [~naggety@39.red-2-142-55.dynamicip.rima-tde.net] has joined #navit 12:42 -!- Horwitz [~mich1@p200300800E50D700022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 12:42 -!- mode/#navit [+o Horwitz] by ChanServ 13:32 -!- Horwitz [~mich1@p200300800E50D700022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds] 14:18 -!- Horwitz [~mich1@p200300800E56C300022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 14:18 -!- mode/#navit [+o Horwitz] by ChanServ 14:22 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.] 14:44 -!- Horwitz [~mich1@p200300800E56C300022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 14:45 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 14:46 -!- mode/#navit [+v xenos1984] by ChanServ 16:07 -!- noradtux [~noradtux@2a04:4540:8c00:4001:b5f2:e9ae:5080:d905] has quit [Quit: Bye] 16:09 -!- noradtux [~noradtux@134.101.136.227] has joined #navit 16:18 #navit: <@KaZeR> hi there 16:18 -!- noradtux [~noradtux@134.101.136.227] has quit [Ping timeout: 256 seconds] 16:19 -!- noradtux [~noradtux@2a04:4540:8c00:4001:b50e:2162:e4a:6a93] has joined #navit 16:28 -!- noradtux [~noradtux@2a04:4540:8c00:4001:b50e:2162:e4a:6a93] has quit [Ping timeout: 256 seconds] 16:31 #navit: <+ilovekiruna> hi KaZeR 16:31 #navit: <+ilovekiruna> have you seen my questions from yesterday? 16:32 #navit: <@KaZeR> i've read the log yeah. i'm not sure about background_gc, i would have to check 16:33 #navit: <+ilovekiruna> what i am after now is that i want to first understand how the map switches to night mode 16:33 #navit: <+ilovekiruna> and implement the same then for auxmap 16:39 -!- noradtux [~noradtux@port-34443.pppoe.wtnet.de] has joined #navit 16:43 #navit: <@KaZeR> ilovekiruna: are you looking for how it's triggered, or for how the actual switch is implemented? 17:13 #navit: <+jkoan> hi @all 17:15 #navit: <@KaZeR> hey jkoan 17:45 #navit: <+ilovekiruna> hi jkoan 17:51 #navit: <+ilovekiruna> KaZeR: the trigger is here? void navit_layout_switch(struct navit *n) { 17:51 #navit: <+ilovekiruna> https://github.com/navit-gps/navit/blob/07006013135b619029f26df579a0ac6acb86cd4a/navit/navit.c#L3206 18:44 -!- noradtux [~noradtux@port-34443.pppoe.wtnet.de] has quit [Ping timeout: 245 seconds] 18:49 -!- noradtux [~noradtux@port-57006.pppoe.wtnet.de] has joined #navit 19:39 #navit: <@KaZeR> ilovekiruna: exactly. but most of that function is really about computing sunset/sunrise times. The actual layout switch is here : https://github.com/navit-gps/navit/blob/07006013135b619029f26df579a0ac6acb86cd4a/navit/navit.c#L3273 19:41 #navit: <+ilovekiruna> KaZeR: my understanding is now, that I somehow need to identify the current layout and compare it to l->dayname and l->nightname 19:41 #navit: <+ilovekiruna> then I could use that in osd_auxmap_draw 19:41 #navit: <+ilovekiruna> is that somehow the right way to go? 19:46 #navit: <@KaZeR> that's one way to go yes. eventually we might need to refactor the navit_layout_switch() so that it doesn't use navit's default layout 19:47 #navit: <@KaZeR> you want the auxmap to match navit's default layout or you want it to be different? 19:48 -!- mvglasow [~mvglasow@dslb-188-104-118-094.188.104.pools.vodafone-ip.de] has joined #navit 20:02 #navit: <+ilovekiruna> I want that auxmap follows the day/night switch as the main map 20:03 #navit: <+ilovekiruna> I was also thinking if one should refactor more and rather give this option to all osds 20:03 #navit: <+ilovekiruna> then one could for example adjust the font color depending on day and night 20:16 #navit: <+ilovekiruna> KaZeR: what do you think? 20:22 #navit: <@KaZeR> > I want that auxmap follows the day/night switch as the main map 20:23 #navit: <@KaZeR> you want to switch at the same time, or you also want to switch to the same layout ? 20:26 #navit: <+ilovekiruna> just at the same time 20:32 -!- mvglasow [~mvglasow@dslb-188-104-118-094.188.104.pools.vodafone-ip.de] has quit [Quit: Leaving] 20:41 #navit: <@KaZeR> ok, then there's probably 2 ways to do it. add some kind of hook to the layout switch function. Better long term solution, but more difficult to implement 20:42 #navit: <@KaZeR> or reimplement a part of it in the osd code. Easier, and a good approach would be to rework slightly the existing function so that it doesn't pull the layout from navit->layout but from the arguments 20:42 #navit: <@KaZeR> makes sense? 20:42 #navit: <+ilovekiruna> am still trying a bit to understand 20:44 #navit: <@KaZeR> so the issue is that void navit_layout_switch(struct navit *n) operates directly on navit->layout 20:44 #navit: <+ilovekiruna> existing function means osd_auxmap_draw 20:45 #navit: <@KaZeR> by existing function i meant navit_layout_switch 20:46 #navit: <@KaZeR> this returns a void currently. If you change that as int, you could have the function return a value telling us IF we should change the layout 20:46 #navit: <@KaZeR> and then let the caller do the change 20:47 #navit: <+ilovekiruna> probably my problem right now is that I dont know who the "caller" is 20:47 #navit: <+ilovekiruna> or where it is called 20:47 #navit: <@KaZeR> so https://github.com/navit-gps/navit/blob/07006013135b619029f26df579a0ac6acb86cd4a/navit/navit.c#L3273 becomes "return true" 20:48 #navit: <@KaZeR> https://github.com/navit-gps/navit/blob/07006013135b619029f26df579a0ac6acb86cd4a/navit/navit.c#L2955 becomes "if navit_layout_switch(this_) { navit_set_layout_by_name(n,l->dayname); } " 20:50 #navit: <+ilovekiruna> is this the only place where navit_layout_switch is used in the code? 21:07 #navit: <@KaZeR> i think so yes 21:28 #navit: <+ilovekiruna> it is on two positions in navit.c 21:38 #navit: <+ilovekiruna> KaZeR: I will sleep now, but will still check logs tomorrow 21:38 #navit: <+ilovekiruna> in case you have any comments 21:38 #navit: <+ilovekiruna> good night 22:26 #navit: <@KaZeR> ilovekiruna: oh you're right. The one is navit_cmd_switch_layout_day_night is used when triggering the switch from the menu or an OSD though. it comes from the commands table 22:50 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.] --- Log closed Wed Jun 13 00:00:15 2018