--- Log opened Mon Sep 10 00:00:48 2018 04:52 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 04:52 -!- mode/#navit [+v xenos1984] by ChanServ 06:10 -!- naggety [~naggety@29.red-2-141-96.dynamicip.rima-tde.net] has joined #navit 14:00 -!- naggety [~naggety@29.red-2-141-96.dynamicip.rima-tde.net] has quit [Quit: Konversation terminated!] 14:10 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.] 15:04 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 15:04 -!- mode/#navit [+v xenos1984] by ChanServ 16:24 #navit: <@KaZeR> hi there 16:39 #navit: <+jkoan> hi KaZeR 16:39 #navit: <+jkoan> whats up? 16:40 #navit: <+jkoan> https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strcmp0 said that g_strcmp0 shoule be available since 2.16, bu that is the support glib version? 16:41 -!- aerostitch [~aerostitc@c-24-23-228-135.hsd1.ca.comcast.net] has joined #navit 16:41 #navit: <+jkoan> hi aerostitch 16:41 #navit: <+jkoan> just looked at the g_strcmp0 issue 16:43 #navit: < aerostitch> Hey jkoan 17:05 #navit: <@KaZeR> jkoan: not sure i get your question 17:05 #navit: <@KaZeR> hey aerostitch 17:06 #navit: <+jkoan> what version our support glib has? 17:08 #navit: <@KaZeR> ha, you said 17:08 #navit: <@KaZeR> "that is" when you probably meant "what is" hence my confusion :) 17:08 #navit: <+jkoan> yeah, sorry ^^ 17:08 #navit: <@KaZeR> mmm good question. the header isn't very helpful 17:10 #navit: <@KaZeR> all we seem to have is this: 17:10 #navit: <@KaZeR> commit 072514dc52da4aeaad01779a85f07c357862ca02 17:10 #navit: <@KaZeR> Author: martin-s 17:11 #navit: <@KaZeR> Date: Sat Oct 18 17:25:16 2008 +0000 17:11 #navit: <@KaZeR> Add:Core:Added necessary modifications for glib to compile from within navit 17:12 #navit: <+jkoan> but it seems to be lower then 2.16 17:21 #navit: < aerostitch> Given how many files there are, I think we only embed a small subset of it 17:21 #navit: < aerostitch> maybe we just need to document how we update it somewhere 17:22 #navit: < aerostitch> I think we only need the memory-related method 17:22 #navit: < aerostitch> and the string manipulations ones 17:22 #navit: < aerostitch> and the core types 17:32 #navit: <+jkoan> or we switch to a new methode by removing support and add https://cmake.org/cmake/help/v3.0/module/ExternalProject.html 17:35 #navit: <@KaZeR> removing support might require a broader discussion, I think that at least tryagain would need to approve 17:37 #navit: <+jkoan> i dont think we should not discuss to long because its only build things, and software development should develop software. If we would have to support something, like the espeak c port it should be a subproject, not in the main repo 17:40 #navit: < Mineque> evening 17:40 #navit: <+jkoan> hi Mineque 17:41 #navit: <+jkoan> Mineque: ehat do you think about my message about removing support and add another way? 17:43 #navit: < Mineque> jkoan nice that you want to include me in disscussion but i can only add mess. Not aware of navit development at all 17:43 #navit: < Mineque> sorry 17:44 #navit: < aerostitch> I think that if we are not supposed to put in support stuffs that are not in the upstream repo, then we should use the upstream repo as external project. 17:45 #navit: < aerostitch> But if we are supposed to do changes specific to navit in those files, then I agree that having the support libs in a separate repo could be a discussion that we should probably have 17:46 #navit: <@KaZeR> "Add:Core:Added necessary modifications for glib to compile from within navit " 17:46 #navit: <@KaZeR> so yeah a plain upstream repo did not work at that time. maybe it's different today 17:46 #navit: <@KaZeR> we need to test :) 17:47 #navit: <+jkoan> probably some changes inside navit core are needed, but i think its better to do those instead of maintaining completely outdated support things 18:02 #navit: < aerostitch> Should I wait for a 2nd review on https://github.com/navit-gps/navit/pull/663 or can I merge? 18:28 #navit: <+jkoan> aerostitch: I want to wait for a second approval or until 7 days are gone 18:28 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Disconnected by services] 18:28 #navit: <+jkoan> To let everyone enough time to disagree with the change 18:30 #navit: < aerostitch> sounds good to me :) 18:30 #navit: < aerostitch> I'll make other small changes like that in the week so that it's easier to review 18:31 #navit: < aerostitch> if I have the time to 19:28 #navit: <+jkoan> Sounds nice 19:28 #navit: <+jkoan> Do you want to give the removal of support a try and add it as cmake external? 19:36 #navit: <+jkoan> KaZeR: why does aerostitch don't have voice or admin in this channel? 19:36 #navit: < genesis> hi 21:39 #navit: < aerostitch> I can try if I find the time this week for glib 23:43 -!- aerostitch [~aerostitc@c-24-23-228-135.hsd1.ca.comcast.net] has quit [Quit: Leaving] --- Log closed Tue Sep 11 00:00:49 2018