--- Log opened Mon Oct 29 00:00:42 2018 00:10 #navit: <+ilovekiruna> KaZeR: sailfish builds seem to work more reliable on the machine executor 00:10 #navit: <+ilovekiruna> I created now a PR for you to review the changes 00:10 #navit: <+ilovekiruna> how would you like to proceed? 05:12 -!- ilovekiruna [~ilovekiru@p200300D10F4B30BBC4FEA39368A56B20.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 05:59 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 05:59 -!- mode/#navit [+v xenos1984] by ChanServ 07:28 -!- naggety [~naggety@163.red-80-27-248.dynamicip.rima-tde.net] has joined #navit 10:22 -!- ilovekiruna [~ilovekiru@p200300D10F4B30539DA2776097F9BAB7.dip0.t-ipconnect.de] has joined #navit 10:22 -!- mode/#navit [+v ilovekiruna] by ChanServ 11:17 -!- genesis [~genesis@unaffiliated/genesis] has quit [Ping timeout: 260 seconds] 11:30 -!- genesis [~genesis@unaffiliated/genesis] has joined #navit 14:26 -!- ilovekiruna [~ilovekiru@p200300D10F4B30539DA2776097F9BAB7.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 15:06 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.] 15:22 -!- naggety [~naggety@163.red-80-27-248.dynamicip.rima-tde.net] has quit [Quit: Konversation terminated!] 16:02 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 16:02 -!- mode/#navit [+v xenos1984] by ChanServ 16:24 #navit: <@KaZeR> hi there 17:19 -!- ilovekiruna [~ilovekiru@p200300D10F4B30539DA2776097F9BAB7.dip0.t-ipconnect.de] has joined #navit 17:19 -!- mode/#navit [+v ilovekiruna] by ChanServ 17:20 #navit: <+ilovekiruna> hi KaZeR 18:03 #navit: <@KaZeR> 'sup ilovekiruna ? 18:24 #navit: <+ilovekiruna> KaZeR: you saw my PR? What should we do about the forum entry? I wrote now that the executor works 18:45 #navit: <@KaZeR> hoehnp added some commits on May 14, 2017 18:45 #navit: <@KaZeR> we need to clean your branch i think 18:45 #navit: <@KaZeR> are all of the commits from the PR really relevant? 18:54 #navit: <+ilovekiruna> so you want me to make a new branch with just the modifications? 18:55 #navit: <+ilovekiruna> can see if I mange that on Wednesday 19:01 #navit: <@KaZeR> > so you want me to make a new branch with just the modifications? 19:02 #navit: <@KaZeR> yeah you should probably do that everytime. It makes the review much much easier 19:02 #navit: <@KaZeR> there's multiple ways to get your current PR simpler, like rebasing. i can help you with that 19:04 #navit: <+ilovekiruna> are PRs with just one commit really useful? 19:05 #navit: <+ilovekiruna> am just now travelling that's why I would do it on Wed 19:37 #navit: <@KaZeR> i'm not saying that PR should have only one commit - just that there's multiple "merge branch from master" in your list :) 19:37 #navit: <@KaZeR> but actually it looks like you touched only one file. so we might be good, don 19:37 #navit: <@KaZeR> don't bother 19:38 #navit: <@KaZeR> could you link to a successful cci build in the description? 19:38 #navit: <@KaZeR> also if this works, we can remove the travis integration right? 20:04 #navit: <+ilovekiruna> KaZeR: I didnt mean just exactly the current PR 20:04 #navit: <+ilovekiruna> I mean it more generic 20:04 #navit: <+ilovekiruna> sure, will link that 20:05 #navit: <+ilovekiruna> I think we could remove travis again 20:20 #navit: < genesis> had you fixed coverity in cci ? 20:54 #navit: <@KaZeR> ilovekiruna: as long as we don't have a bunch of merges it's fine. we can reduce that by always branching off trunk, and iterating quickly on the PRs 20:54 #navit: <@KaZeR> genesis: not yet although i took a lot at it over the week-end. Still unsure why our coverage dropped 20:54 #navit: <+ilovekiruna> KaZeR: ok 20:55 #navit: <+ilovekiruna> KaZeR: how would u like to proceed about the forum entry? Just stay with the machine executor now? 20:55 #navit: <@KaZeR> if it works yeah. it'll get closed automatically after 3 months if nobody replies. if someone replies, maybe we will be able to find a fix 20:56 #navit: <+ilovekiruna> I just answered that machine executor works, but dont understand the difference why it works now 21:04 #navit: <@KaZeR> perfect. maybe it'll give someone who knows better than us a clue about our issue 21:23 #navit: <+ilovekiruna> KaZeR: if that is then finally sorted, next step would be again auxmap 21:23 #navit: <+ilovekiruna> hopefully we can discuss next week again 21:33 #navit: <+ilovekiruna> KaZeR: happier with #709? 21:37 #navit: <@KaZeR> ilovekiruna: way cleaner thanks. Maybe remove travis in the same PR? 21:37 #navit: <+ilovekiruna> sure, can do that 21:38 #navit: <+ilovekiruna> so one more commit 21:39 #navit: <+ilovekiruna> KaZeR: hope i was not a too much pita 21:46 #navit: <@KaZeR> absolutely not 21:47 #navit: <@KaZeR> maybe just add the circleci link where the build succeeded to the description and i think it'll be good to go 23:21 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.] --- Log closed Tue Oct 30 00:00:44 2018