[00:03:03] *** Joins: Peetz0r (~Peetz0r@217-19-18-67.dsl.cambrium.nl)
[00:46:25] *** Quits: Horwitz (~mich1@p200300ec9f092e00022268fffe64e7c4.dip0.t-ipconnect.de) (Ping timeout: 240 seconds)
[00:59:17] *** Joins: Horwitz (~mich1@p200300ec9f029900022268fffe64e7c4.dip0.t-ipconnect.de)
[00:59:17] *** ChanServ sets mode: +o Horwitz
[02:23:42] *** Quits: genesis (~genesis@unaffiliated/genesis) (Remote host closed the connection)
[02:25:17] *** Joins: genesis (~genesis@unaffiliated/genesis)
[02:25:17] *** ChanServ sets mode: +v genesis
[05:55:32] <Navit> <jkoan> I know that we did it. We reformatted everything
[07:04:05] <ilovekiruna> jkoan, in this scope I also notice that whitespaces connected with * changed position completely
[07:05:34] <ilovekiruna> for example:
[07:05:37] <ilovekiruna> FILE                   *f;
[07:05:41] <ilovekiruna> became:
[07:05:51] <ilovekiruna> FILE* f;
[07:16:21] <Navit> <jkoan> Is this a problem?
[07:16:38] <ilovekiruna> that is my question
[07:16:48] <ilovekiruna> dont remember that small detail of C right now
[07:17:08] <ilovekiruna> is FILE*f == FILE* f == FILE *F ?
[07:17:59] <Navit> <jkoan> I don't think so. But I also don't remember if there's s difference between type* var; and type *var;
[07:18:41] <ilovekiruna> because it is a difference I saw, but cant judge right now
[07:18:47] <Navit> <jkoan> Type var; is definitely something else because the star is for pointers
[07:19:03] <ilovekiruna> exactly
[07:19:08] <ilovekiruna> 1*2 is simple
[07:19:11] <ilovekiruna> if it is calculations
[07:20:32] <ilovekiruna> from here I understand it is basically all the same: https://softwareengineering.stackexchange.com/questions/7305/int-i-or-int-i-or-int-i
[08:04:21] *** Quits: genesis (~genesis@unaffiliated/genesis) (Remote host closed the connection)
[08:04:53] *** Joins: genesis (~genesis@unaffiliated/genesis)
[08:04:53] *** ChanServ sets mode: +v genesis
[11:43:33] *** Quits: ilovekiruna (~ilovekiru@2a02:8108:d00:110:d96c:93f4:8be1:474b) (Quit: Konversation terminated!)
[11:59:16] <Navit> <jkoan> @ilovekiruna do you have some time to review my first PR for hacktoberfest today?
[12:00:02] <Navit> <ilovekiruna> sure jkoan
[12:00:07] <Navit> <ilovekiruna> please just point me there
[12:00:46] <Navit> <jkoan> i am writing the PR body, and after that i am ready to go 🙂
[12:09:07] <Navit> <ilovekiruna> what about codefactor?
[12:10:39] <Navit> <ilovekiruna> I still see some CI issues
[12:10:56] <Navit> <ilovekiruna> I think we should at least make sure that it builds in all platforms I would say
[12:26:34] <Navit> <ilovekiruna> I see some issues in your new file
[12:30:46] <Navit> <jkoan> yep, i too, need to look into the issues
[12:31:34] <Navit> <jkoan> for issues you found please just review and leave comment on the lines with review as "Request changes"
[12:33:40] <Navit> <ilovekiruna> ok
[12:33:42] <Navit> <ilovekiruna> as you wish
[12:34:19] <Navit> <jkoan> oh, the build issue should be easy, thats just the wrong for loop 😄 will fix this later, afk for some time, but will work on this again today
[12:34:36] <Navit> <jkoan> thx ilovekiruna
[13:02:41] <Navit> <ilovekiruna> @jkoan How quickly does it fill your HDD?
[13:14:39] *** Joins: ilovekiruna (~ilovekiru@2a02:8108:d00:110:d96c:93f4:8be1:474b)
[13:14:39] *** ChanServ sets mode: +v ilovekiruna
[13:15:07] <ilovekiruna> jkoan: maybe my 4th PR in hacktoberfest could be my changes to the swedish translation
[13:15:27] <ilovekiruna> but I would like C.H.~: to approve things first
[13:23:38] <Navit> <ilovekiruna> @jkoan : have we verified that his code actually changes anything? meaning we once compiled it with our code and saw a different behaviour?
[13:40:54] <Navit> <jkoan> > @jkoan : have we verified that his code actually changes anything? meaning we once compiled it with our code and saw a different behaviour? @ilovekiruna which code, don't get the context
[13:41:20] <ilovekiruna> jkoan: I mean the osd_core thingy I am checking right now
[13:42:20] <Navit> <jkoan> > @jkoan How quickly does it fill your HDD? @ilovekiruna not much, it should only create two files once a refresh cycles. So normally only 2 Images a second
[13:43:10] <Navit> <jkoan> > <ilovekiruna> @jkoan I mean the osd_core thingy I am checking right now @IRC Gateway no, haven't checked it compiled, but logical it made sense when I viewed it
[13:43:26] <ilovekiruna> ah, ok, then I am carrying on :-)
[13:47:37] <Navit> <jkoan> for #1061 no issues found? 🙂
[13:48:28] <ilovekiruna> I didnt. the codefactor thing, from my understanding we didnt take it so strict
[13:48:35] <ilovekiruna> at least what I remember
[13:48:48] <Navit> <jkoan> yep, i will still look into it
[13:49:36] <Navit> <jkoan> "Complex Method" is always a little meh, because sometimes you cant simplify it with ease
[13:50:00] <ilovekiruna> for NULL in attr_search, I belive was sth that we decided to drop because the argument was always NULL
[13:50:03] <Navit> <samor> if I have navit running, and next connect gps module, it won't load gps data. If GPS is running, and then I launch navit, everything is ok. Is there any parameter for <vehicle> to force-trying load data?
[13:50:04] <ilovekiruna> do you remember?
[13:50:40] <Navit> <jkoan> @ilovekiruna yes, i dit this one, it was always NULL, so ther was no reason to keep it
[13:51:44] <Navit> <jkoan> @samor the best solution would be to use navit with gpsd instead of directly via file
[15:56:13] *** Quits: ilovekiruna (~ilovekiru@2a02:8108:d00:110:d96c:93f4:8be1:474b) (Remote host closed the connection)
[22:40:09] *** Quits: xenos1984 (~xenos1984@52d8-fe94-b6ff-0250-a680-87ce-07d0-2001.dyn.estpak.ee) (Quit: Leaving.)