--- Log opened Tue Oct 31 00:00:00 2017 00:35 -!- Horwitz [~mich1@p200300800E002D00022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds] 00:48 -!- Horwitz [~mich1@p200300800E000600022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 00:48 -!- mode/#navit [+o Horwitz] by ChanServ 01:34 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has quit [Ping timeout: 240 seconds] 01:37 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has joined #navit 02:47 -!- noradtux [~noradtux@2a04:4540:8c00:bc01:ec4:7aff:fe33:3dc1] has quit [Ping timeout: 264 seconds] 02:51 -!- noradtux [~noradtux@2a04:4540:8c01:1c01:ec4:7aff:fe33:3dc1] has joined #navit 06:47 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 07:41 -!- ZeroOne [~ZeroOne@91.114.11.118] has joined #navit 09:50 #navit: < ilovekiruna> i saw, am not too excited :D 10:00 -!- bzed [~bzed@shell.bzed.at] has quit [Read error: Connection reset by peer] 10:01 -!- bzed_ [~bzed@shell.bzed.at] has joined #navit 10:01 -!- bzed_ is now known as bzed 10:10 -!- ZeroOne [~ZeroOne@91.114.11.118] has quit [Read error: Connection reset by peer] 10:10 -!- KaZeR [~kazer@ec2-54-70-178-135.us-west-2.compute.amazonaws.com] has quit [Ping timeout: 248 seconds] 10:11 -!- KaZeR [~kazer@ec2-54-70-178-135.us-west-2.compute.amazonaws.com] has joined #navit 11:00 -!- ilovekiruna [~ilovekiru@h131n8-ll-a31.ias.bredband.telia.com] has quit [Ping timeout: 246 seconds] 14:11 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.] 15:56 #navit: < youte> hi 16:14 #navit: < KaZeR> hi 16:41 -!- charles__ [48241adf@gateway/web/freenode/ip.72.36.26.223] has joined #navit 16:42 #navit: < charles__> I have several problems. Navit 0.5.0~svn5900+dfsg.1-1 on Debian jessie (8.x). 16:43 #navit: < charles__> 1) Imperial doesn't seem to work. 16:43 #navit: < charles__> 2) I pulled the latest from the git repo. cmake fails. 16:44 #navit: < charles__> 3) Tried to sign up at the forum. Attempts to creat a new login lead to a dead end: a non-existent page. 16:50 #navit: < charles__> 4) I pulled an area from openstreetmaps that does not include any actual coastline. Everything shows up as blue (I assume that means ocean). How can I fix that? 17:09 #navit: < KaZeR> hi charles__ and welcome! 17:09 #navit: < charles__> Thx 17:09 #navit: < KaZeR> oh wow, svn5900 that's super old. we switched to git 2 years ago, and we're probably at rev6900 now 17:10 #navit: < charles__> :-) yeah, one reason I tried pulling in git head. 17:10 #navit: < KaZeR> let's look into your cmake issue (until debian updates the package, but it should be soon as we have a release coming up) 17:10 #navit: < KaZeR> do you have the exact error message? 17:11 #navit: < charles__> jess is old stable; stretch is stable (9.x). I am looking at upgrading to stretch. Need a decent map/nav program to do it. 17:11 #navit: < charles__> Anyway, on to cmake... 17:12 #navit: < charles__> charles@hawk:~/versioned/navit/navit-build$ cmake ../navit CMake Error at fib-1.1/CMakeLists.txt:1 (supportlib_add_library): Unknown CMake command "supportlib_add_library". -- Configuring incomplete, errors occurred! See also "/home/charles/versioned/navit/navit-build/CMakeFiles/CMakeOutput.log". charles@hawk:~/versioned/navit/navit-build$ 17:12 #navit: < KaZeR> ok. what's your cmake version? 17:12 #navit: < charles__> Yuchh. Is there a better way to paste multiple lines here? 17:13 #navit: < KaZeR> yeah, navit.pastebin.org or some similar pastebin service 17:13 #navit: < charles__> cmake 3.0.2 17:13 #navit: < KaZeR> ok. i wonder if you shouldn't use cmake ../ instead of cmake ../navit 17:14 #navit: < charles__> Doh. 17:14 #navit: < KaZeR> :D 17:14 #navit: < charles__> charles@hawk:~/versioned/navit/navit-build$ cmake .. CMake Error: The source "/home/charles/versioned/navit/CMakeLists.txt" does not match the source "/home/charles/versioned/navit/navit/CMakeLists.txt" used to generate cache. Re-run cmake with a different source directory. 17:15 #navit: < KaZeR> ah yeah you need to delete the content of the current folder as you are attempting a build for another directory 17:15 #navit: < KaZeR> don't forget the hidden files 17:15 #navit: < charles__> I suspect I can just rm -r * to get rid of the cache files. 17:15 #navit: < KaZeR> actually no hidden files it seems. 17:16 #navit: < charles__> OK, that works. I seem to have gotten a good build. 17:16 #navit: < KaZeR> cool. should solve 1) and 2) in one strike 17:18 #navit: < charles__> OK, where's the executable? 17:18 #navit: < KaZeR> so the build results will be in the navit subfolder. if you don't want to install it's ok but you should probably run navit from the subfolder then 17:18 #navit: < KaZeR> to ensure it can find the required libs 17:19 #navit: < KaZeR> the forum registration does send me to the wiki, which is the intended behavior. what did you get? 17:19 #navit: < KaZeR> ah! i see the issue now. thanks, fixing it 17:20 #navit: < charles__> Right, sends me to the wiki. Then you have to chick on another link. That one is dead. 17:20 #navit: < charles__> "Registration currently requires confirmation, click here Special:RequestAccount to request an user." 17:21 #navit: < KaZeR> fixed the link. it's because we removed a plugin recently 17:22 #navit: < charles__> OK, got the create account page. Thx. 17:23 #navit: < KaZeR> np 17:23 #navit: < KaZeR> so now we're left with 1) to confirm and 4), right? 17:23 #navit: < charles__> Still on #2. Can't find the executable. 17:24 #navit: < KaZeR> ah. did you run make after running cmake ? 17:24 #navit: < charles__> Last command was 'cmake ..' 17:24 #navit: < charles__> No. Will try..... 17:25 #navit: < charles__> compiling.... Does not look like the standard make output. 17:25 #navit: < KaZeR> so in short cmake configures the build for your platform. like autogen.sh, ./configure and this kind of tools. you still need to actually compile once it's configure 17:26 #navit: < charles__> OK, looks like a good build, except for a lot of untranslatable messages. 17:27 #navit: < KaZeR> yeah, translations level varies depending on the language : https://translations.launchpad.net/navit 17:27 #navit: < KaZeR> but it's just an info 17:28 #navit: < charles__> https://pastebin.com/cA5ZGvcK 17:29 #navit: < KaZeR> ok. so navit's default config is to use the 'internal' gui with the 'gtk_drawing_area' graphics driver 17:30 #navit: < KaZeR> looks like you are missing a dependency and this driver was not compiled 17:30 #navit: < charles__> I have a modified navit.xml. It callse for the gtk interface, so that is one problem. 17:30 #navit: < KaZeR> internal can work with different graphics, but gtk requires gtk_drawing_area 17:30 #navit: < KaZeR> do you still see the summary at the end of cmake? 17:30 #navit: < KaZeR> (if you don't you can just run cmake again) 17:31 #navit: < charles__> Yes. I can scroll back as needed. 17:31 #navit: < KaZeR> ok. under graphics, what's enabled? 17:33 #navit: < charles__> Under 'gui': Enabled gtk ( GTK libs found ) Enabled internal ( Default ) Enabled qml ( Qt Declarative found ) Disabled qt5_qml ( Qt5 Declarative not found ) 17:33 #navit: < KaZeR> ok. and under graphics? 17:33 #navit: < KaZeR> oh wait 17:34 #navit: < KaZeR> " KaZeR | so the build results will be in the navit subfolder. if you don't want to install it's ok but you should probably run navit from the subfolder then " 17:34 #navit: < KaZeR> so instead of navit/navit, try cd navit; ./navit 17:34 #navit: < charles__> Enabled gtk_drawing_area ( GTK libs found ) 17:35 #navit: < KaZeR> yeah, just noticed that you started navit using navit/navit 17:35 #navit: < KaZeR> if you didn't run make install, navit will look for the plugins into the current folder, which won't work if you start it from outside the navit subfolder 17:35 #navit: < charles__> cd navit ; ./navit works. Much better. 17:36 #navit: < charles__> Program launched, I got the demo map, then it picked up my GPS receiver, and changed locations. 17:37 #navit: < KaZeR> looking good so far 17:37 #navit: < charles__> But no menus. 17:37 #navit: < KaZeR> what happens if you click the map? 17:37 #navit: < charles__> No map, either. 17:37 #navit: < KaZeR> (or the yellow background if you don't have a map) 17:38 #navit: < charles__> Ah, I get the interface. Tell me again how these things are "intuitive"? 17:38 #navit: < KaZeR> oh they are not. much work needed there. 17:38 #navit: < KaZeR> so you mentionned having downloaded a map and having a custom config file to use gtk 17:38 #navit: < KaZeR> you probably did that for the packaged version of navit. 17:39 #navit: < KaZeR> when you run navit from its subfolder like right now, it looks for the files in there. it allows us to test different versions at the same time 17:39 #navit: < charles__> Right. Everything is in ~/.navit. Which is a symlink. 17:39 #navit: < KaZeR> well ~/.navit is one good way to do it 17:40 #navit: < charles__> OK, so I should be able to un-install the packaged version & run the compile version. 17:40 #navit: < KaZeR> yep. 17:40 #navit: < KaZeR> the packaged version is 2+ years old 17:40 #navit: < charles__> Can I tell the local version of navit to pick up my config stuff? 17:40 #navit: < KaZeR> absolutely. ./navit -c ~/.navit/navit.xml should work 17:40 #navit: < KaZeR> you can also run make install from the parent folder 17:41 #navit: < KaZeR> (where you ran cmake) and then you won't have to worry about paths anymore 17:41 #navit: < KaZeR> (and it'll pick the config from your homedir just like the packaged version) 17:41 #navit: < charles__> OK, that picked up my map & the gui. 17:41 #navit: < KaZeR> cool. everything solved? 17:42 #navit: < charles__> Right, which is what I want eventually. However, I thought I should test it first. 17:42 #navit: < charles__> Speed is still in km/h. 17:43 #navit: < KaZeR> ok. how did you change the setting? 17:43 #navit: < charles__> In navit.xml. 17:43 #navit: < charles__> 17:47 -!- MarcR [~MarcR@p5DD901E7.dip0.t-ipconnect.de] has joined #navit 17:47 #navit: < MarcR> /msg NickServ identify marcra## 17:48 #navit: < MarcR> lol :P 17:51 #navit: < MarcR> Hi Everybody 17:58 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 18:01 #navit: < KaZeR> hey MarcR 18:01 #navit: < KaZeR> i've pushed an updated image for you 18:01 #navit: < KaZeR> hey xenos1984 18:01 #navit: < KaZeR> charles__: ok give me a few mintues 18:01 #navit: < charles__> OK. Thx. 18:07 #navit: < MarcR> KaZeR: Ah cool. 19:12 #navit: < KaZeR> charles__: you're using the GTK ui, right? 19:14 #navit: < charles__> Correct. 19:14 #navit: < KaZeR> looks like GTK doesn't honor the imperial settings indeed. That's definitely a bug 19:14 #navit: < KaZeR> works well when using internal though : https://imgur.com/a/Uw92Q 19:14 #navit: < KaZeR> out of curiosity, why do you prefer gtk over internal? 19:15 #navit: < charles__> Well, that was before you told me to click on the internal. 19:15 #navit: < charles__> But I'm used to the pull-down menues & prefer them over the internal. 19:17 #navit: < KaZeR> ok! rationale behind my question : gtk was navit's first UI. it's quite usable on a PC, not so much on mobile devices 19:17 #navit: < KaZeR> we put more efforts into internal over the last years and didn't really improve gtk (that's probably why imperial setting isn't working) 19:18 #navit: < KaZeR> the future will probably be qt5/qml2 for something more modern (internal has some limitations) 19:18 #navit: < KaZeR> it shouldn't be too hard to get imperial setting working on gtk though 19:18 #navit: < charles__> ok. 19:18 #navit: < charles__> so are you hinting this is a "won't fix"? :-) 19:19 #navit: < KaZeR> no, not really, because this particular issue shouldn't be too difficult to fix 19:19 #navit: < charles__> Great. 19:19 #navit: < KaZeR> also, gtk is actually useful when we want to investigate map-related issues 19:19 #navit: < KaZeR> do you have some coding skills? 19:19 #navit: < charles__> Some. Only about 40 years. Where should I look? 19:20 #navit: < MarcR> oh nice. the Rasperry got a Kernel Update. now Navit over X-Server got a nice performance push. on my packet install 19:22 #navit: < KaZeR> charles__: nice ! 19:22 #navit: < KaZeR> charles__: here's where it happens for gtk : https://github.com/navit-gps/navit/blob/trunk/navit/gui/gtk/gui_gtk_statusbar.c#L148 19:22 #navit: < KaZeR> you can see that the unit is hardcoded 19:24 #navit: < charles__> Yep. Some of the conversion factors you need for this are in the gpsd header files. 19:24 #navit: < KaZeR> actually i think that it's the only issue. When generating a route, the roadbook does use imperial units 19:25 #navit: < KaZeR> so it looks like we only need to fix the status bar 19:25 #navit: < KaZeR> MarcR: nice! which kernel are you using now? 19:27 #navit: < charles__> OK. It looks like all you need to change are the height and speed. 19:28 #navit: < charles__> Linux hawk 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux 19:30 #navit: < charles__> Feel free to steal from https://github.com/charlescurley/gnome-gps, src/gnome-gps.c, line 395 et seq. 19:32 #navit: < KaZeR> thanks charles__. would you like to submit it as a PR ? 19:32 #navit: < charles__> PR? 19:32 #navit: < MarcR> KaZeR: 4.9.59-v7+ 19:33 #navit: < charles__> Let's see if I can code it up & send you a patch. 19:33 #navit: < KaZeR> charles__: pull request. i can assist, and thanks! 19:34 #navit: < KaZeR> MarcR: were you using 4.4 before? 19:34 #navit: < MarcR> KaZeR: should be it, yes. the one before. 19:35 #navit: < KaZeR> ok. the image i shared is already using 4.9 :) 19:35 #navit: < MarcR> Ah ok 19:36 #navit: < MarcR> I will test the image you shared next days. 19:36 #navit: < MarcR> WHat points do I get my eyes on? 19:37 #navit: < KaZeR> this image has navit preconfigured to use qt5 graphics and qml2 ui. So you only need to log in and start navit. Next image will have autostart 19:37 #navit: < KaZeR> you can of course switch back to internal ui, and keep the qt5 graphics which will allow you to run navit without X 19:37 #navit: < KaZeR> this is a work in progress but i have high hopes for it. Testing navit on pi will soon be super easy 19:38 #navit: < KaZeR> any feedback is welcome 19:38 #navit: < MarcR> Ok got it 19:38 #navit: < MarcR> does anyone has experience with kodi ? 19:39 #navit: < KaZeR> i do yeah 19:39 #navit: < KaZeR> you want to integrate kodi with navit? 19:40 #navit: < MarcR> yes sir 19:41 #navit: < KaZeR> i have mixed feelings about that. There's this guy who did an amazing job putting it all together. But in my opinion it still feels hackish 19:41 #navit: < MarcR> I already installed Kodi 17.5 Krypton, with CarPC Tronimized Skin. I have to check how I can activate Navit, when I hit the Navigation Button. 19:41 #navit: < KaZeR> and running both kodi and navit at the same time puts some pressure on the pi 19:42 #navit: < MarcR> yeap 19:42 #navit: < MarcR> I have the same toughts about that. 19:43 #navit: < KaZeR> ok, so let's take it the other way: what features do you want in your car? 19:43 #navit: < MarcR> maybe I will do self coding a python ui - but my python coding skills are .... 0 atm ;-) 19:44 #navit: < KaZeR> or... you can help us build an amazing qml2 ui. 19:44 #navit: < KaZeR> almost no coding required. 19:45 #navit: < KaZeR> https://d33sqmjvzgs8hq.cloudfront.net/wp-content/uploads/2015/02/QtQuickDesigner.png 19:46 #navit: < MarcR> Navigation - of course ;-) / Bluetooth Free Speaking (speakerphone) with Contacts I can scroll via ui, from my phone (iphone) - dashcam recording. 19:46 #navit: < KaZeR> what would be your source of music in your car? 19:47 #navit: < MarcR> oh yeah. dab+ would be cool. but it looks like there is no really working solution for it 19:47 #navit: < MarcR> so fm radio over the pi fm add on 19:47 #navit: < MarcR> oh the quickdesigner looks interesting 19:48 #navit: < MarcR> if there is a way to design a qml2 ui for the project, this would be cool too 19:48 #navit: < MarcR> no need for kodi 19:48 #navit: < charles__> KaZeR: Dang, it may take more than just that one line. 19:49 #navit: < KaZeR> fm radio is totally possible. I have a proof of concept somewhere using a i2c radio receiver. Jkoan has been working on radio too (but focused on TMC) 19:49 #navit: < MarcR> I'm away to eat something 19:49 #navit: < charles__> The variables are already converted when we get there. 19:51 #navit: < KaZeR> MarcR: you can design a qml2 ui with qtdesigner. Look into navit/gui/qt5_qml/editor/ there is a demo project 19:51 #navit: < KaZeR> charles__: i wonder if it's not just an issue of having the unit being hardcoded when we display it 19:51 #navit: < KaZeR> the value might be already converted from when it is manipulated upstream of the UI 19:51 -!- MarcR is now known as MarcR|away 19:58 #navit: < charles__> Right. I'm doing the conversion now with something like imperial ? calculate imperial unit : unit 20:10 -!- MarcR|away is now known as MarcR 20:25 #navit: < charles__> KaZeR: I'm getting messages along the lines of "'Fix the speech tag in navit.xml to let navit say:' 'Follow the road for the next 250 feet'" 20:26 #navit: < charles__> So the routing seems to know about imperial. 20:45 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Disconnected by services] 20:45 -!- xenos19841 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 20:49 -!- ilovekiruna [~ilovekiru@h131n8-ll-a31.ias.bredband.telia.com] has joined #navit 20:52 -!- Locke [~MarcR@p5DD901E7.dip0.t-ipconnect.de] has joined #navit 20:53 -!- MarcR [~MarcR@p5DD901E7.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20:53 -!- Locke [~MarcR@p5DD901E7.dip0.t-ipconnect.de] has quit [Client Quit] 20:53 -!- MarcR [~MarcR@p5DD901E7.dip0.t-ipconnect.de] has joined #navit 21:00 #navit: < KaZeR> charles__: sorry was afk 21:01 #navit: < KaZeR> charles__: yep that sounds about right. If you click on the roadbook icon you'll see that the instructions are using imperial 21:01 #navit: < KaZeR> routing ( and navigation) is handled by navit core, so it's shared between internal and gtk 21:03 #navit: < charles__> no worries. 21:04 #navit: < charles__> So, how do I make the variable imperial visible inside statusbar_route_update? 21:05 #navit: < ilovekiruna> hi KaZeR: 21:05 #navit: < charles__> Assuming that the variable imperial declared in navit.c is the one I want. 21:05 #navit: < ilovekiruna> need to check out again if you wrote sth to me during the day 21:06 #navit: < ilovekiruna> didnt come up with things :( 21:07 #navit: < KaZeR> charles__: so pretty much everything in navit is built using attributes. Here's how to fetch the `imperial` attribute : https://github.com/navit-gps/navit/blob/trunk/navit/navigation.c#L1030-L1031 21:08 #navit: < KaZeR> ilovekiruna: not yet. The example i shared yesterday was a really crude example. The idea was that we would use relevant items names instead of the places in my example 21:11 #navit: < ilovekiruna> KaZeR: yes, saw it 21:11 #navit: < ilovekiruna> really pretty crude 21:11 #navit: < KaZeR> haha 21:12 #navit: < KaZeR> if you don't like the idea it's fine. Sozi is actually really cool 21:13 #navit: < ilovekiruna> in general i really always wanted to have a sozi presentation at some point in time 21:13 #navit: < MarcR> KaZeR: is there a way to reload the osd - while navit is running. I'm designing my osd atm, via xml file. 21:13 #navit: < ilovekiruna> but as it is a bit new, it takes time to shap up in my head ;-) 21:14 #navit: < KaZeR> ilovekiruna: one thing i was thinking too is that you can do something cool, like start the presentation while quite zoomed on the map, moving between items. Then at the end you zoom out fully, and the map spells "Navit" 21:14 #navit: < charles__> KaZeR: /home/charles/versioned/navit/navit/gui/gtk/gui_gtk_statusbar.c:103:31: error: dereferencing pointer to incomplete type if (navit_get_attr(nav->navit, attr_imperial, &attr, NULL)) 21:14 #navit: < charles__> It seems to dislike nav->navit 21:14 #navit: < ilovekiruna> KaZeR: sounds really cool, am just worried on two things :-S 21:15 #navit: < KaZeR> charles__: https://github.com/navit-gps/navit/blob/trunk/navit/gui/gtk/gui_gtk_statusbar.c#L83 the struct *navit object here is called navit instead of nav (yep we should be more consistent :( ) 21:16 #navit: < ilovekiruna> KaZeR: 1. how to arrange for the final idea you have, and 2. if we spend too much time on design and too little on content 21:16 #navit: < KaZeR> charles__: scratch that. in the navigation.c, we use nav->navit (nav being a struct *navigation) 21:16 #navit: < KaZeR> so you probably just need navit here (as nav->navit would point to a navit object) 21:17 #navit: < KaZeR> ilovekiruna: valid concerns. One way to address this is to work on a usual presentation and convert it into sozi if we have time and if we still like the idea 21:22 #navit: < ilovekiruna> KaZeR: I think that should be the way to go. Least risks 21:22 #navit: < KaZeR> works for me 21:22 #navit: < charles__> The function call is: statusbar_route_update(struct statusbar_priv *this, struct navit *navit, struct vehicle *v) 21:22 #navit: < ilovekiruna> I mean we could then also just put the the slides as a svg in sozi 21:23 #navit: < KaZeR> maybe we can rope youte into helping with the fake map. I suck at inkscape 21:23 #navit: < KaZeR> charles__: yes, so navit_get_attr(navit, ... should work 21:23 #navit: < ilovekiruna> KaZeR: you mean right now or when we are done with the content? 21:23 #navit: < charles__> OK, I'm officially confused. 21:23 #navit: < KaZeR> ilovekiruna: in parallel maybe? 21:24 #navit: < KaZeR> charles__: my explanations sucked :) 21:25 #navit: < charles__> No, I just don't know enough about the inner workis of navit. 21:25 #navit: < charles__> Anyway eperimentation.... This works: if (navit_get_attr(navit, attr_imperial, &attr, NULL)) 21:26 #navit: < charles__> compiles, anyway.... 21:26 #navit: < KaZeR> should work yes. here's more details. struct *navit ' 21:27 #navit: < KaZeR> s prototype is here : http://navit-gps.github.io/navit/structnavit.html 21:27 #navit: < KaZeR> struct * navigation prototype is here : http://navit-gps.github.io/navit/structnavigation.html 21:27 #navit: < KaZeR> the GTK method we want to alter already has a struct * navit object in its parameters, so we can access it directly 21:28 #navit: < KaZeR> the navigation example i shared, where we fetch the imperial settings, didn't, instead it had a struct *navigation object 21:28 #navit: < KaZeR> but if you look at the navigation prototype, it contains a pointer to a struct navit object (line 10 or so, after the callbacks) 21:28 #navit: < charles__> OK, that seems to work. 21:29 #navit: < KaZeR> so if what you have is a struct * navigation nav object, you can access the struct * navit navit object via nav->navit 21:29 #navit: < charles__> I compiled with my local instance of imperial initialized to TRUE. Got imperial. 21:29 #navit: < KaZeR> nice! 21:30 #navit: < charles__> Changed it to FALSE. Still got imperial. So I expect the get_attrib call worked. 21:30 #navit: < charles__> Changed the attribute in navit.xml to 0. Got metric. 21:30 #navit: < KaZeR> oh wow, actual tests, i love it :D 21:30 #navit: < charles__> Other tests I sould apply? 21:31 #navit: < charles__> Yeah, I know, testing. It's a bad habit. I hope you won't hold it against me. :-) 21:31 #navit: < KaZeR> haha 21:36 #navit: < charles__> Any more tests you can think of, or shall I make up a diff for you. 21:38 #navit: < charles__> I have some errands to run. Back in 1-2 hrs. 21:38 #navit: < KaZeR> i think that we're good to go for the patch. I can help you submit a PR once you're ready 21:38 #navit: < charles__> OK. 21:39 #navit: < charles__> .quit 21:39 #navit: < charles__> OK, how do I log out? Close the window, I guess. 21:39 -!- charles__ [48241adf@gateway/web/freenode/ip.72.36.26.223] has quit [Quit: Page closed] 21:40 #navit: < ilovekiruna> KaZeR: what about xenos1984? 21:42 #navit: < KaZeR> no news yet. Let me email him right now 21:44 #navit: < KaZeR> done 22:47 #navit: < KaZeR> MarcR: ping me whenever you want to learn more about the qml2 designer if you're interested 22:52 #navit: < MarcR> KaZeR: Ok I'm very interested, I will give you a ping. 22:52 #navit: < MarcR> KaZeR: working on the osd atm 22:56 #navit: < KaZeR> cool! 22:57 #navit: < MarcR> KaZeR: hmmm the it looks like navigation.item.destination_time[arrival] has the wrong type in my navit - the time should be 01:15pm (01:15 Uhr) but it is 1+00:15 22:58 #navit: < KaZeR> ah, +1 means tomorrow. i wonder if we could make this better 22:59 #navit: < MarcR> Ah Ok 22:59 #navit: < KaZeR> so your trip should be 24h15 minutes long, right? 23:00 #navit: < KaZeR> i don't remember if it's only "tomorrow" or if it's more than 24h 23:00 #navit: < MarcR> hmm 23:00 #navit: < MarcR> looks like there was a small calculating bug 23:00 #navit: < KaZeR> woopsie 23:00 -!- xenos19841 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.] 23:01 #navit: < MarcR> now its 00:19 arrvial - / 00:18 desttime.remaining 23:02 #navit: < MarcR> could also be a gps locating problam 23:02 #navit: < MarcR> problem 23:02 #navit: < MarcR> gps is hopping around atm. cause its in my office 23:02 #navit: < MarcR> not in my car, under the sky, soo 23:05 #navit: < KaZeR> so no bug? :) 23:05 #navit: < MarcR> is there a list with available "onboard" button icons ? 23:06 #navit: < MarcR> I think not, but I will keep that in mind. 23:06 -!- charles__ [48241adf@gateway/web/freenode/ip.72.36.26.223] has joined #navit 23:06 #navit: < KaZeR> onboard ? 23:06 #navit: < charles__> yep. 23:06 #navit: < MarcR> I think, next week. I have my 7" Touch, so I can test navit in my car :) 23:06 #navit: < KaZeR> that was actually intended for MarcR but welcome back :) 23:06 #navit: < KaZeR> MarcR: cool! 23:07 #navit: < KaZeR> how are you going to power it? cigarette plug thinggy? 23:07 #navit: < MarcR> I have a big power bank. should do the job for some test drives 23:07 #navit: < MarcR> or the cigarette plug yeah 23:08 #navit: < MarcR> zoom_in.xpm <- Onboard Button Icon ? 23:09 #navit: < KaZeR> oh you want a list of the available icons? 23:09 #navit: < KaZeR> or possible actions? 23:09 #navit: < MarcR> available icons 23:10 #navit: < MarcR> possible actions, i have found in the wiki 23:10 #navit: < MarcR> i have found the source dir with icons, but not what they look like in wiki 23:12 #navit: < KaZeR> yeah we should probably compile a list of these 23:12 #navit: < charles__> OK, how I set up for a pull request? 23:13 #navit: < charles__> Do I first have to commit my changes? 23:13 #navit: < KaZeR> charles__: i guess that the github project you linked to earlier is yours, right? 23:13 #navit: < charles__> Yes. 23:13 #navit: < KaZeR> ok. so easiest way is probably to fork navit in your own repo, commit there in a branch (fix_gtk_imperial_use maybe) and submit a PR from there 23:13 #navit: < KaZeR> i can provide more details for any step, just ask 23:14 #navit: < MarcR> KaZeR: should be cool. with the icons. 23:14 #navit: < KaZeR> yep. could be something that we could easily script, if you're into that 23:14 #navit: < charles__> I have a local clone of navit here. Does that help? 23:16 #navit: < KaZeR> it would if you had write permissions to our repo. which we can make happen if you're interested 23:17 #navit: < charles__> Works for me. Whatever is easiest. 23:17 #navit: < charles__> Do you need an ssh key? 23:17 #navit: < KaZeR> nop, just your github user key 23:18 #navit: < KaZeR> please have a look at https://wiki.navit-project.org/index.php/Programming_guidelines while i send you the invite. One thing that's not yet in that page is that we shouldn't push to trunk, only to branches 23:19 #navit: < ilovekiruna> KaZeR: what is icon_diving used for? 23:19 #navit: < ilovekiruna> for a swimming pool? 23:19 #navit: < KaZeR> charles__: ah found your username 23:19 #navit: < KaZeR> ilovekiruna: a diving spot? 23:20 #navit: < KaZeR> you can often dive near shores/small cliffs 23:20 #navit: < ilovekiruna> ah, ok, now got it 23:20 #navit: < ilovekiruna> thought of diving more like swimming ;-) 23:20 #navit: < ilovekiruna> no clue but that was stuck in my mind 23:20 #navit: < KaZeR> well it's related :) 23:21 #navit: < KaZeR> charles__: invite sent. please be careful to use branches 23:23 #navit: < charles__> Got the invite. Sorry, not an experienced github user. Now what? 23:25 #navit: < KaZeR> np everybody has to learn :) 23:25 #navit: < KaZeR> now, create a branch : git checkout -b fix_gtk_imperial_use 23:26 #navit: < KaZeR> commit your changes : git commit -m "fix:gtk:fixed missing imperial units in the GTK ui" 23:26 #navit: < KaZeR> check if it's right : git status (should say "on branch something") 23:26 #navit: < KaZeR> git push 23:28 #navit: < charles__> In my commit message, I usually uncomment the modified file(s). That OK here? 23:28 #navit: < KaZeR> what do you mean? 23:29 #navit: < charles__> I commit w/o the -m option. git tosses a draft commit message into my editor. It has possibly useful info, all comented out. I uncomment the list of modified files. 23:29 #navit: < KaZeR> oh ok yeah that totally works 23:29 #navit: < charles__> OK. 23:30 #navit: < KaZeR> end result is actually the same :) 23:34 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has quit [Ping timeout: 248 seconds] 23:35 #navit: < KaZeR> once you'll have pushed, you can head to the github web ui. select the branch from the menu, and you'll have a button 'new pull request' 23:35 #navit: < charles__> Pretty much the same. Anyway, see if you have it. 23:35 #navit: < charles__> git checkout fix_gtk_imperial_use 23:36 #navit: < KaZeR> did you push? i don't see it 23:36 #navit: < charles__> I did, but got "Everything up-to-date" 23:37 #navit: < KaZeR> odd 23:37 #navit: < KaZeR> can you please share the git commands and their outputs? 23:37 #navit: < KaZeR> maybe also a `git status` ? 23:37 #navit: < charles__> See if you have commit cb3bf5cc9ed87b925ce8acb7af3bf4978e188f00 23:38 #navit: < KaZeR> nop don't see it 23:40 #navit: < charles__> https://pastebin.com/HcaMHgi7 23:41 #navit: < KaZeR> oh i know what's wrong 23:41 #navit: < KaZeR> you used emacs ;) 23:41 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has joined #navit 23:41 #navit: < charles__> Oh, VIle insults! :-) 23:42 #navit: < KaZeR> haha 23:42 #navit: < KaZeR> more seriously, here's probably your issue : There is no tracking information for the current branch. 23:42 #navit: < KaZeR> so git branch --set-upstream-to=origin/fix_gtk_imperial_use fix_gtk_imperial_use 23:43 #navit: < KaZeR> you can change your default git config to do that for you. it's called simple mode or something like that 23:45 #navit: < KaZeR> after the git branch command, git push should work 23:45 #navit: < charles__> That complained, but told me to use "git push -u", which I did. See if you have it. 23:46 #navit: < KaZeR> actually, `git push --set-upstream origin fix_gtk_imperial_use` should do both a tthe same time 23:46 #navit: < KaZeR> mm nop still don't see it. can you try the push i just pasted/ 23:46 #navit: < KaZeR> ? 23:47 #navit: < charles__> OK, that looks more like it. See if you have it. 23:48 #navit: < KaZeR> yep it's here now. 3rd time's the charm. 23:48 #navit: < KaZeR> ok there's one last thing to do : submit the pull request from the branch 23:48 #navit: < KaZeR> https://github.com/navit-gps/navit/tree/fix_gtk_imperial_use -> `new pull request` 23:49 #navit: < KaZeR> it's good practice to put a word about the rationale of the PR, and what you tested. then you're done! 23:56 #navit: < KaZeR> perfect. now let's just wait for the tests to finish and we can merge 23:57 #navit: < KaZeR> from joining the chan for the first time to pushing your first PR in just a few hours, that has to be a record. 23:57 #navit: < KaZeR> `he fix is on branch fix_gtk_imperial_use` -> the PR actually tells us that :) 23:57 #navit: < KaZeR> `charlescurley wants to merge 1 commit into trunk from fix_gtk_imperial_use` 23:58 #navit: < charles__> Better to document it, especially when one isn't sure. 23:58 #navit: < KaZeR> true --- Log closed Wed Nov 01 00:00:02 2017