--- Log opened Tue Apr 03 00:00:11 2018
00:26 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has quit [Ping timeout: 260 seconds]
00:27 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has joined #navit
00:47 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has quit [Ping timeout: 240 seconds]
01:01 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has joined #navit
04:07 -!- noradtux [~noradtux@port-5306.pppoe.wtnet.de] has quit [Ping timeout: 256 seconds]
04:07 -!- noradtux [~noradtux@46.59.214.95] has joined #navit
04:29 -!- aerostitch [~aerostitc@c-67-164-55-119.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
04:40 -!- ilovekiruna [~ilovekiru@ip1f129b37.dynamic.kabel-deutschland.de] has quit [Quit: Konversation terminated!]
04:47 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit
04:47 -!- mode/#navit [+v xenos1984] by ChanServ
10:12 -!- aerostitch [~aerostitc@c-67-164-55-119.hsd1.ca.comcast.net] has joined #navit
12:17 -!- ColdFyre [~lenny@24-113-172-199.wavecable.com] has quit [Ping timeout: 256 seconds]
12:29 -!- ColdFyre [~lenny@24-113-172-199.wavecable.com] has joined #navit
13:40 #navit: <+jkoan> Hi @all
13:43 #navit: <+jkoan> Hi aerostitch
14:21 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.]
15:09 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit
15:09 -!- mode/#navit [+v xenos1984] by ChanServ
15:33 #navit: < aerostitch> Hi jkoan
15:34 #navit: <+jkoan> i dont think you need to close you tickets only because one person from the team does not like *new* ideas. I know so many people which hate everything whats new only because its new
15:34 #navit: <+jkoan> :D
15:35 #navit: <+jkoan> and for the ticket with the missing icon youte could help, but in generally its no problem when an icon is missing
15:56 #navit: < aerostitch> Well I closed it because 2 of the biggest contributors were against it
15:57 #navit: <+jkoan> two?
15:58 #navit: < aerostitch> sleske in #424 and mvglasow in #425
15:59 #navit: < aerostitch> for the missing icon, I just wanted to fix the typo! :D
15:59 #navit: < aerostitch> which I did in a PR during the night
16:19 #navit: < aerostitch> anyway, you can reopen it if you consider that more people will answer positively and you can get a quorum of agreement
16:20 #navit: <+jkoan> i will definitely comment on when i have time
16:53 #navit: <@KaZeR> hi there
16:54 #navit: <@KaZeR> aerostitch: yeah i agree with jkoan here. we should have kept the discussion going for a bit
16:55 #navit: <@KaZeR> jkoan: let's make sure to give others a chance to review PRs too. Unless it's to fix a breakage in the build system, we can keep the PR open for at least a couple of days to give other a chance to review
16:55 #navit: <@KaZeR> i'm thinking about the warning in maptool that aerostitch fixed for example
16:56 #navit: <+jkoan> the new one with g_* functions, i left it open exactly because of this
16:57 #navit: <+jkoan> but even throught, its trunk not master = its dev not production  ;)
16:57 #navit: <+jkoan> if we always keep trunk as stable as stable we will never move big things
17:02 #navit: <@KaZeR> i was thinking about this one specifically : https://github.com/navit-gps/navit/pull/419
17:02 #navit: <@KaZeR> it's the same kind of issue that ilovekiruna helped fix some time ago. it's easy to fix the warning, but fixing the actual underlying issue is sometime trickier because you need to make sure that you properly handle returns
17:03 #navit: <@KaZeR> don't get me wrong i do appreciate your help with reviews :) but i think that keeping the PR open for just a couple of days would foster more collaboration
17:03 #navit: <+jkoan> hm okay, i see. agree with you
17:03 #navit: <@KaZeR> it's actually really nice to see that despite they are almost never on IRC, sleske and tryagain are actively watching what's going on in github
17:05 #navit: <+jkoan> by the way, probably realloc could be replaced with g_realloc in this case (the PR you showed)
17:05 #navit: <@KaZeR> absolutely
17:07 #navit: < aerostitch> yes but that's why I created https://github.com/navit-gps/navit/issues/427
17:07 #navit: < aerostitch> and started by a 1st step which is: https://github.com/navit-gps/navit/pull/429
17:09 #navit: < aerostitch> not sure exactly when I'll have to do the other changes. I'm working a bit too much on opensource stuffs and am running late on paid work, so trying to balance that a bit better
17:09 #navit: <+jkoan> and i left it open because i thought: "code looks good but i dont know glib good enought" then i reread glib reference and "class" programming in c. and after that i would say perfect code but i want to let also others say something to the PR
17:09 #navit: < aerostitch> but those different function migrations can be treated totally independently even if they are in the same spirit
17:10 #navit: < aerostitch> yeah no worries, I got that
17:11 #navit: < aerostitch> What is often done in other projects is that 1 person reviews and puts his approval and another persons double-checks and merges
17:11 #navit: <+jkoan> sounds good to me
17:11 #navit: <@KaZeR> perfect
17:12 #navit: <+jkoan> so no battles any more? :D
17:12 #navit: <+jkoan> schlafen?
17:12 #navit: <+jkoan> fuck
17:12 #navit: <+jkoan> fail
17:12 #navit: <@KaZeR> as a rule of thumb, if it involves maptool, tryagain (mdankov) is the one with the better knowledge, so definitely worth tagging him in the PR
17:12 #navit: <@KaZeR> jkoan: well it's no battle, it's normal and safe to have some disagreements :)
17:13 #navit: <+jkoan> yes, sounds good
17:14 #navit: <+jkoan> i was looking at the maptool code also to see if i can probably find ways to optimize boath, output filesize and convert speed
17:14 #navit: < aerostitch> KaZeR: good idea I'll ping him
17:17 #navit: <@KaZeR> perfect
17:36 #navit: < aerostitch> There's something else we can do: assign the PR to 3 or 3 people based on which file has been changed at the end of the CI
17:37 #navit: < aerostitch> using a predefined mapping
17:37 #navit: < aerostitch> in the kubernetes project as well as in the ansible project they have bots that do things like that
17:38 #navit: < aerostitch> but I think a run at the end of the CI job if successful would do the trick
17:38 #navit: < aerostitch> What do you think jkoan and KaZeR?
17:44 #navit: <@KaZeR> i like that
18:12 -!- ilovekiruna [~ilovekiru@ip1f129b37.dynamic.kabel-deutschland.de] has joined #navit
18:12 -!- mode/#navit [+v ilovekiruna] by ChanServ
18:12 #navit: <@KaZeR> hey ilovekiruna 
18:13 #navit: <+ilovekiruna> Hey KaZeR
18:15 #navit: < aerostitch> Opened https://github.com/navit-gps/navit/issues/431 to put your ideas in KaZeR
18:15 #navit: < aerostitch> ;)
18:34 #navit: <+ilovekiruna> KaZeR: whats up?
18:40 -!- noradtux [~noradtux@46.59.214.95] has quit [Ping timeout: 260 seconds]
18:42 -!- noradtux [~noradtux@46.59.214.95] has joined #navit
18:45 #navit: <@KaZeR> not much. been quite busy lately, hopefully it'll get better soon and i can resume work on some cool features for navit!
18:52 #navit: <+ilovekiruna> KaZeR: same here :(
18:52 #navit: <+ilovekiruna> btw: I also learned what i also need to implement for auxmap
18:52 #navit: <+ilovekiruna> apparently, it doesnt follow the night-mode
18:55 #navit: <@KaZeR> ha, interesting. this is actually a good thing as it enables us to use a different map layout 
19:10 #navit: <+ilovekiruna> KaZeR: have you seen any issues with sourceforge lately?
19:11 #navit: <@KaZeR> i'm not really using it anymore
19:12 #navit: <+ilovekiruna> one other project, I am building for work, has its git repo there
19:12 #navit: <+ilovekiruna> today cloning was really bad performance
19:12 #navit: <+ilovekiruna> at least for me
19:13 #navit: < aerostitch> I had trouble cloning sourceforge stuffs for months
19:14 #navit: < aerostitch> and even navigating to it
19:14 #navit: <+ilovekiruna> aerostitch: also today?
19:14 #navit: < aerostitch> most of the people I know ended up setting up github mirrors
19:14 #navit: <+ilovekiruna> making vm images with packer failed today, just because of this :(
19:15 #navit: < aerostitch> I haven't tried today but I've tried maybe 6 or seven times over the last 2 months and the usage was constantly horrible
19:15 #navit: < aerostitch> timeouts on the web side and on git clone
19:15 #navit: < aerostitch> it just became unusable for me
19:16 #navit: <+ilovekiruna> I am now using the unofficial github mirror
20:49 #navit: <@KaZeR> https://github.com/navit-gps/navit/pull/429#issuecomment-378396493 : awesome example of good collaboration
21:03 #navit: < aerostitch> :)
21:06 #navit: < aerostitch> Thank you daddy :D
21:08 #navit: <@KaZeR> haha
21:30 #navit: <@KaZeR> jkoan: want to have a look at the change that we need to do for the play store compliance?
21:39 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.]
22:21 #navit: <@KaZeR> http://blog.klocwork.com/static-analysis/does-the-v-in-genivi-represent-vulnerability/ uh-oh
22:24 -!- j_f-f [~quassel@rs-7.jff-webhosting.net] has quit [Ping timeout: 264 seconds]
22:33 -!- j_f-f [~quassel@62.138.18.44] has joined #navit
22:42 -!- KaZeR [~kazer@ec2-54-70-178-135.us-west-2.compute.amazonaws.com] has quit [Quit: WeeChat 1.4]
22:42 -!- kazer [~kazer@ec2-54-70-178-135.us-west-2.compute.amazonaws.com] has joined #navit
22:43 -!- mode/#navit [+o kazer] by ChanServ
23:03 -!- Horwitz [~mich1@p200300800E727700022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
23:16 -!- Horwitz [~mich1@p200300800E007200022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit
23:16 -!- mode/#navit [+o Horwitz] by ChanServ
--- Log closed Wed Apr 04 00:00:12 2018