--- Log opened Thu May 24 00:00:40 2018 00:39 -!- ColdFyre [~lenny@24-113-80-215.wavecable.com] has quit [Ping timeout: 240 seconds] 00:41 -!- ColdFyre [~lenny@24-113-80-215.wavecable.com] has joined #navit 04:39 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has joined #navit 04:39 -!- mode/#navit [+v xenos1984] by ChanServ 05:07 -!- noradtux [~noradtux@port-2470.pppoe.wtnet.de] has quit [Ping timeout: 256 seconds] 05:08 -!- noradtux [~noradtux@2a04:4540:8c07:7b01::1] has joined #navit 06:00 -!- naggety [~naggety@145.red-37-158-27.dynamicip.rima-tde.net] has joined #navit 10:30 -!- pmckinley [~Mutter@213.205.194.41] has joined #navit 10:30 -!- pmckinley [~Mutter@213.205.194.41] has quit [Client Quit] 11:17 #navit: <@KaZeR> hi there 14:01 -!- naggety [~naggety@145.red-37-158-27.dynamicip.rima-tde.net] has quit [Quit: Konversation terminated!] 14:06 -!- pmckinley [~peter@213.205.194.41] has joined #navit 14:07 -!- pmckinley [~peter@213.205.194.41] has left #navit [] 14:10 #navit: < aerostitch> hi friend 14:27 -!- xenos1984 [~xenos1984@2001:bb8:2002:200:6651:6ff:fe53:a120] has quit [Quit: Leaving.] 14:32 #navit: <@KaZeR> 'sup aerostitch ? 14:40 #navit: <+jkoan> Hi Kazer 14:40 #navit: <+jkoan> What up? :D 14:43 #navit: <@KaZeR> hey jkoan. I'm in your TZ for a few days :) 14:44 #navit: <+jkoan> Yay :) so more work on navit or a lot of jetlag? 14:46 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has joined #navit 14:46 -!- mode/#navit [+v xenos1984] by ChanServ 14:48 #navit: <@KaZeR> yeah jetlag for today :) 14:48 #navit: <@KaZeR> will try to get a couple of things done thought 14:48 #navit: <@KaZeR> i discovered github checks today : https://developer.github.com/v3/checks/ this has been release a few weeks ago 14:53 #navit: <+jkoan> did you enabled Travis? 14:57 #navit: <@KaZeR> i have, to have a look at the checks thing. 14:58 #navit: <@KaZeR> I thought that this would be a good fit after we merge aerostitch's work on code linting 14:58 #navit: <@KaZeR> then we could have travis report lint violations directly in the PRs 14:58 #navit: <@KaZeR> currently circleci doesn't report to checks, but it seems to be in the works 15:13 #navit: <+jkoan> is aerostitch also onlne? :D 15:15 #navit: < aerostitch> yes he is 15:15 #navit: <+jkoan> hi aerostitch 15:15 #navit: < aerostitch> hi jkoan 15:15 #navit: <+jkoan> what do you mean by https://github.com/navit-gps/navit/projects/2#card-9308177 this? 15:15 #navit: < aerostitch> finishing my breajfast :D 15:16 #navit: <+jkoan> oh okay :d 15:16 #navit: <+jkoan> *:D 15:16 #navit: < aerostitch> I think we should define 2 different sets of artifacts: the ones corresponding to releases (tags) and the ones corresponding to normal builds 15:17 #navit: < aerostitch> and that cards was for the normal builds 15:17 #navit: < aerostitch> updated the card 15:17 #navit: < aerostitch> is it clearer? 15:17 #navit: < aerostitch> Makes sense? 15:18 #navit: <+jkoan> but we cant delete artefacts :D 15:19 #navit: < aerostitch> really? :D 15:19 #navit: < aerostitch> that sounds silly 15:20 #navit: <@KaZeR> yeah we can't :) 15:20 #navit: < aerostitch> lol 15:20 #navit: <@KaZeR> hopefully circleci got a nice deal on the s3 pricing 15:21 #navit: < aerostitch> lol 15:21 #navit: < aerostitch> so this entire project can't be done right? 15:22 #navit: <+jkoan> we need to check waht we want to upload, that would make sense 15:23 #navit: < aerostitch> ok. 15:23 #navit: < aerostitch> you can delete those 2 cards then 15:24 #navit: < aerostitch> nvm I deleted them 15:57 #navit: <+jkoan> KaZeR: could you comment on this? https://github.com/navit-gps/navit/pull/452 16:01 #navit: <@KaZeR> ha yes i need to do that 16:01 #navit: <@KaZeR> thanks for the reminder 16:53 #navit: <@KaZeR> aerostitch: where's the export button? I triple checked, can't see it 16:53 #navit: < aerostitch> lol 16:53 #navit: <@KaZeR> i'm getting old. I'm going blind it seems 16:53 #navit: < aerostitch> when you're in the view page 16:53 #navit: < aerostitch> on the top left corner you got a S 16:54 #navit: < aerostitch> in a purple circle 16:54 #navit: < aerostitch> that's not that 16:54 #navit: < aerostitch> :D 16:54 #navit: < aerostitch> Under it you have 3 horizontal bars 16:54 #navit: < aerostitch> click on that 16:54 #navit: < aerostitch> You'll have the list of your views there 16:55 #navit: <@KaZeR> the horizontal bars are called a "hamburger". true story :) 16:55 #navit: < aerostitch> at the end of the line corresponding to your view you have an arrow that points to down 16:55 #navit: < aerostitch> sure 16:55 #navit: <@KaZeR> oh shit 16:55 #navit: < aerostitch> and that's where you find the export 16:55 #navit: < aerostitch> lol 16:55 #navit: <@KaZeR> damn. do you think that they could have made it less obvious ? 16:55 #navit: < aerostitch> lol 16:56 #navit: < aerostitch> Are you working on https://github.com/navit-gps/navit/issues/597 or can I push something on it? 16:57 #navit: <@KaZeR> not working on it. wanted to start sharing issues. 16:59 #navit: <@KaZeR> lol the xml file that you can get there isn't even compliant with the standards 17:07 #navit: <+jkoan> KaZeR: have you seen that: https://www.codefactor.io/repository/github/navit-gps/navit/issues really cool 17:11 -!- jandegr [4d6d7a19@gateway/web/freenode/ip.77.109.122.25] has joined #navit 17:16 #navit: <+jkoan> hi jandegr 17:16 #navit: < jandegr> hi all 17:17 #navit: <+jkoan> aerostitch: look here, restyling the code fixes 179 issues and "creates" only 4 new https://www.codefactor.io/repository/github/navit-gps/navit/pull/569 17:18 #navit: < aerostitch> lol 17:18 #navit: < aerostitch> it doesn't really create them! :D 17:19 #navit: < aerostitch> It just touches those lines I guess :D 17:19 #navit: <+jkoan> i know 17:19 #navit: <+jkoan> yes 17:19 #navit: < aerostitch> I need to rebase my branch again 17:19 #navit: <+jkoan> probably to complex to analyse ;) 17:19 #navit: < aerostitch> Hopefully this time I'll get an approval so I can merge! :D 17:19 #navit: <+jkoan> i hope so too 17:23 #navit: < aerostitch> KaZeR is it you making tests with travis checks! :D 17:24 #navit: < aerostitch> Now my PR has red :'( 17:27 #navit: <+jkoan> aerostitch: try push again, i set the option "Build only if .travis.yml is present" 17:27 #navit: <+jkoan> but i was not the person who activated travis 17:27 #navit: < aerostitch> I need to find something to change! :D 17:28 #navit: <+jkoan> only force push? 17:30 #navit: <+jkoan> oh, i could restart the build 17:32 #navit: <+jkoan> fuuu, restart takes the old settings 17:36 #navit: < aerostitch> lol 17:36 #navit: < aerostitch> give me a sec 17:36 #navit: <+jkoan> no problem 17:37 #navit: < aerostitch> damn, how can you see the changes on a PR for coverity? 17:38 #navit: <+jkoan> ?? what? 17:38 #navit: < aerostitch> I'd like to verify that https://github.com/navit-gps/navit/pull/598 really fixes the coverity warning 17:39 #navit: <+jkoan> just look at the checks 17:39 #navit: <+jkoan> "All checks have passed" 17:41 #navit: <+jkoan> the issue KaZeR showed seems to be "private" 17:41 #navit: < aerostitch> yeah but I wanted to see something like https://www.codefactor.io/repository/github/navit-gps/navit/pull/fixed/598 but for coverity 17:44 #navit: <@KaZeR> jkoan: i've seen it, i'm the one who enabled it earlier today :) 17:45 #navit: <+jkoan> KaZeR: where do you got the picture from? https://github.com/navit-gps/navit/issues/597 17:45 #navit: < aerostitch> in the defect view 17:46 #navit: < aerostitch> from https://scan.coverity.com/projects/navit-gps?tab=overview 17:46 #navit: < aerostitch> click on "View Defects" 17:46 #navit: <@KaZeR> aerostitch: we submit builds to coverity only from trunk by default 17:46 #navit: < aerostitch> oh ok 17:46 #navit: <@KaZeR> aerostitch: you can add your branch to the ci/build_linux script 17:46 #navit: <@KaZeR> maybe declare an array for future usage or something 17:47 #navit: <+jkoan> KaZeR: requested access to coverity (again?) 17:48 #navit: < aerostitch> jkoan you're there 17:48 #navit: < aerostitch> it's your gmail address 17:48 #navit: < aerostitch> for your login 17:48 #navit: <+jkoan> ah okay... 17:48 #navit: <+jkoan> its not linked to github, okay 17:49 #navit: <@KaZeR> yeah their github integration is weird 17:49 #navit: <+jkoan> okay, thx 17:49 #navit: <@KaZeR> everytime i log in it wants me to link my GH account. i just press back and it's all good 17:49 #navit: <+jkoan> :D 17:52 #navit: <@KaZeR> jkoan: i've received a request for your coverity account on the gmx address, access granted 17:52 #navit: <+jkoan> cool, thx 17:52 #navit: <+jkoan> this one is linked to github, hopefully this will be better 17:53 #navit: <@KaZeR> cool 17:57 #navit: <+jkoan> KaZeR: what about add those to Readme? 17:57 #navit: <+jkoan> https://img.shields.io/travis/navit-gps/navit/master.svg 17:57 #navit: <+jkoan> https://img.shields.io/circleci/project/github/navit-gps/navit/master.svg 17:57 #navit: <+jkoan> https://www.codefactor.io/repository/github/navit-gps/navit/badge 17:58 #navit: <@KaZeR> travis isn't setup yet, so probably not useful for now 17:58 #navit: <@KaZeR> and we already have the shield for circleci in the readme :) 17:59 #navit: <+jkoan> really ? :D then i haven’t said anything 18:02 #navit: < aerostitch> For https://github.com/navit-gps/navit/pull/598 I was wondering if I should change instead and do the fread outside the if, then print the debug message if over 0, then close, then return 0 or 1 based on the number of bytes 18:03 #navit: < aerostitch> thoughts? 18:05 #navit: <+jkoan> not really :D 18:19 #navit: <@KaZeR> mmm that error is actually a bit weird 18:19 #navit: <@KaZeR> with the == 0 we're actually checking the return value of fread() 18:23 #navit: < aerostitch> yes 18:23 #navit: < aerostitch> but it is there because we don't close the file descriptor if the file is empty or we cannot read it 18:24 #navit: < aerostitch> that's all it says 18:24 #navit: < aerostitch> because we return in the if 18:25 #navit: < aerostitch> if we had an int we assign to 1 and in the if we assign it to 0 , remove the return from the if and return the value of the previously mentioned int it would do the same right KaZeR? 18:25 #navit: < aerostitch> not sure which one is better 18:27 #navit: <@KaZeR> are you taking about 25263? 18:27 #navit: <@KaZeR> 25263 Ignoring number of bytes read 18:27 #navit: <@KaZeR> The number of bytes copied into the buffer can be smaller than the requested number and the buffer can potentially be accessed out of range. 18:36 #navit: < aerostitch> no talking about https://github.com/navit-gps/navit/pull/598 18:36 #navit: < aerostitch> which is for 18:36 #navit: < aerostitch> leaked_storage: Variable f going out of scope leaks the storage it points to. 18:37 #navit: <@KaZeR> eh. fuck today. I blame the jetlag 18:41 #navit: < aerostitch> we could use feof() and ferror() maybe to check whether the file is empty of if there's a read error 18:47 #navit: <@KaZeR> we could also just close(f) in the if before the return i think 18:47 #navit: <@KaZeR> *fclose 18:50 #navit: < aerostitch> that's what I did before 18:50 #navit: < aerostitch> but what do you think about the version I just push right now 18:51 #navit: <@KaZeR> oh right you did it. dude i swear my brain is mush today 18:52 #navit: <@KaZeR> i think that i prefer the previous version, it's more concise 18:55 #navit: < aerostitch> but in the previous one we don't make a difference between empty files and an error right? 18:55 -tomaw(tom@freenode/staff/tomaw)- [Global Notice] Hi all. We need to take services (NickServ, ChanServ and their friends) offline for a few minutes for maintenance. Downtime's expected to be less than 30 minutes. 18:57 -!- ChanServ [ChanServ@services.] has quit [shutting down] 18:58 #navit: <@KaZeR> we do, with the return 0 vs return 1 18:59 #navit: < aerostitch> Hm I thought that a fread on an empty file did return 0 19:02 #navit: < aerostitch> anyway, I reverted to the previous version 19:02 -!- ChanServ [ChanServ@services.] has joined #navit 19:02 -!- ServerMode/#navit [+o ChanServ] by cherryh.freenode.net 19:03 #navit: < aerostitch> when this one is merged I'll rebase #569 so that somebody can add his approval as there will be no red on it anymore! :D 19:06 -tomaw(tom@freenode/staff/tomaw)- [Global Notice] NickServ, ChanServ and their friends are back up and running as normal now! 19:11 -!- ChanServ [ChanServ@services.] has quit [shutting down] 19:13 #navit: <+jkoan> test 19:13 #navit: <+jkoan> "(21:22:37) NickServ: (notice) Account jkoan dropped, forcing logout" what?! 19:15 -mquin(~mike@freenode/staff/mquin)- :[Global Notice] Seems that was premature. There are ongoing issues with services that are being looked into - please bear with us 19:16 #navit: < aerostitch> lol 19:19 -!- jkoan_ [4d14d592@gateway/web/freenode/ip.77.20.213.146] has joined #navit 19:20 -!- ChanServ [ChanServ@services.] has joined #navit 19:20 -!- ServerMode/#navit [+o ChanServ] by cherryh.freenode.net 19:21 -!- jkoan_ [4d14d592@gateway/web/freenode/ip.77.20.213.146] has quit [Client Quit] 19:21 #navit: <+jkoan> dam, now i am not sure if everything with a my bouncer and b my accound is okay 19:22 -!- jandegr [4d6d7a19@gateway/web/freenode/ip.77.109.122.25] has quit [Quit: Page closed] 19:23 -!- Mineque is now known as Guest17253 19:26 -mquin(~mike@freenode/staff/mquin)- :[Global Notice] Services are back now but may be busy for the next few minutes. You may need to identify to NickServ again 19:28 -tomaw(tom@freenode/staff/tomaw)- [Global Notice] As anyone who works with computers knows, they're out to get us. That turned out to be more complicated that it should've been and you may find you need to /msg NickServ IDENTIFY YOURPASSWORD to be able to access your account. Sorry for the noise! 19:33 -mquin(~mike@freenode/staff/mquin)- [Global Notice] Note that if you are having difficulty changing nickname you can identify to NickServ using the format '/msg NickServ identify accountname password' 20:08 #navit: <@KaZeR> aerostitch: i approved #598 20:08 #navit: < aerostitch> thx 20:12 #navit: <@KaZeR> aerostitch: https://www.codefactor.io/repository/github/navit-gps/navit/overview/trunk 20:12 #navit: <@KaZeR> ' 20:12 #navit: <@KaZeR> navit\gui\internal\gui_internal_command.c has greatly improved 20:12 #navit: <@KaZeR> :D 20:12 #navit: < aerostitch> HAHAHAHAHAHA 20:13 #navit: < aerostitch> mine says: navit\map\binfile\binfile.c has gotten worse 20:13 #navit: < aerostitch> lol 20:13 #navit: <@KaZeR> yep 20:13 #navit: <@KaZeR> just saw it 20:13 #navit: < aerostitch> I like the "31 new issues" and just next to it "31 fixed issues" 20:13 #navit: < aerostitch> :D 20:16 -!- pmckinley [~Mutter@2a02:c7d:704f:a100:6ce9:48df:d283:e2bb] has joined #navit 20:16 #navit: < pmckinley> Hello darkness my old friend 20:18 -!- pmckinley [~Mutter@2a02:c7d:704f:a100:6ce9:48df:d283:e2bb] has quit [Client Quit] 20:23 #navit: < aerostitch> I've come to talk with you again 20:23 #navit: < aerostitch> KaZeR I updated https://github.com/navit-gps/navit/pull/569 seems all good now 23:10 -!- xenos1984 [~xenos1984@22-164-191-90.dyn.estpak.ee] has quit [Quit: Leaving.] 23:34 -!- Horwitz [~mich1@p200300800E009900022268FFFE64E7C4.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 23:47 -!- Horwitz [~mich1@p200300800E00A500022268FFFE64E7C4.dip0.t-ipconnect.de] has joined #navit 23:47 -!- mode/#navit [+o Horwitz] by ChanServ --- Log closed Fri May 25 00:00:42 2018