[00:15:09] *** Quits: Horwitz (~mich1@p200300EC9BC40C00022268FFFE64E7C4.dip0.t-ipconnect.de) (Ping timeout: 250 seconds)
[00:28:29] *** Joins: Horwitz (~mich1@p200300EC9BC1AB00022268FFFE64E7C4.dip0.t-ipconnect.de)
[00:28:29] *** ChanServ sets mode: +o Horwitz
[08:58:44] <snooky> hi all
[17:23:32] <kazer> hi snooky 
[17:26:00] <kazer> regarding your missing icons, we would need to add them here : https://github.com/navit-gps/navit/tree/trunk/navit/icons 
[17:26:15] <kazer> we are not using xpm anymore, we switched to svg
[17:26:55] <kazer> it would be great if you could find an icon (has to be under a license that would allow us to use it, such as CC) or design one yourself
[17:58:18] *** Joins: gernot2 (bc637920@dslb-188-099-121-032.188.099.pools.vodafone-ip.de)
[18:00:09] <gernot2> ho
[18:00:12] <gernot2> hi
[18:01:50] <gernot2> I think i found the fix for issue #826 (lag="1" ->crash)
[18:02:13] <gernot2> how to create a pull request?
[18:09:26] <kazer> hi gernot2 
[18:09:29] <kazer> nice!
[18:09:41] <kazer> did you put the fix in a branch somewhere already?
[18:10:10] <gernot2> no, just in a private üull
[18:10:37] <gernot2> git clone https://github.com/navit-gps/navit.git
[18:11:11] <kazer> yep. then create a branch : "git checkout issue/826"  
[18:11:32] <kazer> edit your file, "git commit <yourfile>" and then "git push"
[18:13:01] <gernot2> error: pathspec 'issue/826' did not match any file(s) known to git.
[18:16:19] <gernot2> kazer the  command to create the branch dont work
[18:19:39] <kazer> sorry
[18:19:45] <kazer> git checkout -b issue/826
[18:22:04] <gernot2> it work...
[18:26:23] <kazer> cool. looks like you haven't pushed yet
[18:27:10] <gernot2> no..I had to reget..add branch...
[18:27:17] <kazer> ok no worries :)
[18:33:26] *** Joins: mvglasow (~mvglasow@87.226.6.8)
[18:39:51] <gernot2> kazer The branch is online
[18:56:21] <kazer> perfect. your git client might have told you this, but the last step is to go here https://github.com/navit-gps/navit/compare/issue/826 and actually create the PR
[18:57:38] <kazer> now just to be nitpicky, you change that bit : &coord_geo,NULL) where most coding conventions require a space after the comma like we had before your change ;)
[18:57:48] <kazer> *changed
[18:59:13] <gernot2> thanks
[19:13:27] <gernot2> The PR is online.
[19:26:28] <kazer> all checks passed, PR merged. Thanks gernot2 !
[19:28:42] <gernot2> nice. I test test result on tomtom. At the moment i cant build self.because my cmake version. 
[19:35:06] <gernot2> I tested the fix successful for linux and android
[19:50:46] <gernot2> ok Just testing tomtom. I noticed that the navit binary in the artifacts is not striped.
[19:51:56] <gernot2> The unstriped size is 4.5G and striped it is 840M. With 32M RAM that is very very much. 
[19:53:02] <gernot2> Fix work for tomtom.  ... no other hardware to test.
[19:55:55] <gernot2> sorry.... The GB and MBs... navit tomtom striped is 840KB unstriped 4.5MB
[20:27:46] <gernot2> by
[20:27:53] *** Quits: gernot2 (bc637920@dslb-188-099-121-032.188.099.pools.vodafone-ip.de) (Quit: gernot2)
[22:07:48] *** Quits: mvglasow (~mvglasow@87.226.6.8) (Quit: Leaving)